Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Remove TAN hotline info from footer #67

Merged
merged 3 commits into from
Jan 31, 2023
Merged

Remove TAN hotline info from footer #67

merged 3 commits into from
Jan 31, 2023

Conversation

Ein-Tim
Copy link
Contributor

@Ein-Tim Ein-Tim commented Jan 30, 2023

Description

This PR removes the number of the TAN hotline from the footer. It also removes superfluous test IDs. On top of that, it bumps the copyright year in the footer of the page.

What was changed?

  • src/data/global.json (removal of the hotline info, removal of superfluous test IDs & copyright year bump)

Preview of the changes

You can find a live preview of the changes here: https://cwa-event-landingpage-cmkg3r9bx-ein-tim.vercel.app


This fixes #66.


Internal Tracking ID: EXPOSUREAPP-14643

This commit removes the number of the TAN hotline from the footer.
@Ein-Tim Ein-Tim requested a review from a team January 30, 2023 17:27
Copy link

@GisoSchroederSAP GisoSchroederSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please, go ahead. Thanks fpr the support here!

@MikeMcC399
Copy link
Contributor

@Ein-Tim

I suggest to integrate the update of Copyright year into this PR.

Also there is a problem in the footer http://localhost:8000/de/ with Barrierefreiheits­erklärung which should split into two lines.

image

@MikeMcC399
Copy link
Contributor

@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented Jan 30, 2023

@MikeMcC399

I suggest to integrate the update of Copyright year into this PR.

I'll do this!

Also there is a problem in the footer http://localhost:8000/de/ with Barrierefreiheits­erklärung which should split into two lines.

Interesting. This problem does also exist on my preview page https://cwa-event-landingpage-7q7v64v8a-ein-tim.vercel.app/de/, however, it does not occur on the production https://s.coronawarn.app/de/.

It would probably be good if

  • the issue with the &shy line break is reported in a new issue
  • a new issue is also opened asking for deployment of the code of this repository to the actual production environment after
    1. this PR is merged
    2. the &shy issue is fixed

Please let me know if you want to open these issues or if I should do that.

@MikeMcC399
Copy link
Contributor

@Ein-Tim

The site has not been maintained and there are probably some software changes which haven't been ported from the main cwa-website to this site leading to the different display format. You can see the difference in the generated HTML code.

Anybody who has already got the app installed does not normally see this site displayed anyway.

I leave the actions to you.

@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented Jan 30, 2023

@dsarkar dsarkar added documentation Improvements or additions to documentation mirrored-to-jira and removed documentation Improvements or additions to documentation labels Jan 31, 2023
@larswmh larswmh merged commit 8b3c3ef into corona-warn-app:main Jan 31, 2023
@larswmh
Copy link
Member

larswmh commented Jan 31, 2023

Thanks for your PR @Ein-Tim!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation mirrored-to-jira
Projects
None yet
Development

Successfully merging this pull request may close these issues.

References to TAN Hotline in footer
5 participants