Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Remove "empty" dates/hours from index files #140

Closed
pithumke opened this issue May 17, 2020 · 3 comments · Fixed by #436
Closed

Remove "empty" dates/hours from index files #140

pithumke opened this issue May 17, 2020 · 3 comments · Fixed by #436
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@pithumke
Copy link
Member

Current Implementation

All dates/hours between the first submission and now (last full hour) are included in the index files, even if there were no submissions.

Suggested Enhancement

Only list dates/hours for which there were submissions in the index files. The "empty" date/hour files should, however, still be generated, even if they are not in the index.

Expected Benefits

Mobile clients need to do fewer requests (they can simply skip empty dates/hours).

@michael-burwig
Copy link
Member

Why should the empty files still be generated?

@pithumke
Copy link
Member Author

pithumke commented Jun 2, 2020

Basically to attest that there were really no submissions in that time window (and that the distribution run didn't just fail). Since we are not (yet) signing index files, I guess the best we can do is to just create and sign the empty exports.

@pithumke
Copy link
Member Author

pithumke commented Jun 3, 2020

#436 removed empty dates/hours from the index but did not add the generation of empty export files.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants