Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Implement Google/Apple file and protocol specs #200

Merged
merged 32 commits into from May 21, 2020

Conversation

pithumke
Copy link
Member

@pithumke pithumke commented May 20, 2020

Summary:

  • Updated "external" protocols to latest Google/Apple spec
  • Updated existing code base accordingly
  • Implemented new signing and "zipping" behavior

Open TODOs:

Closes:

Sorry for the large PR 🙈

@pithumke
Copy link
Member Author

Opened new issues for the open TODOs (see PR description). Will resolve those in follow-up PRs (otherwise this one will get even bigger than it already is).

@sonarcloud
Copy link

sonarcloud bot commented May 21, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 42 Code Smells

85.2% 85.2% Coverage
0.0% 0.0% Duplication

Copy link
Member

@michael-burwig michael-burwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧇

@pithumke pithumke merged commit 81b19e7 into master May 21, 2020
@pithumke pithumke deleted the update/file-and-proto-specs branch May 21, 2020 16:19
@hilmarf hilmarf linked an issue Sep 25, 2020 that may be closed by this pull request
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-introduce batching for diagnosis key packages
5 participants