This repository has been archived by the owner on May 16, 2023. It is now read-only.
Submission Service - Enhance TEK's #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tek-approach # Conflicts: # services/submission/src/test/java/app/coronawarn/server/services/submission/controller/PayloadValidationTest.java
ioangut
requested review from
christian-kirschnick,
emmetsap,
EugenM-SAP,
EvgeniiSkrebtcov,
fredrb,
hilmarf,
johanneseschrig,
KevponSAP,
kilbphilippSAP,
michael-burwig,
MKusber,
ole-lilienthal,
pithumke,
sorin-iovita,
stevesap and
UnchartedBull
as code owners
...e/src/test/java/app/coronawarn/server/common/persistence/domain/DiagnosisKeyBuilderTest.java
Outdated
Show resolved
Hide resolved
EugenM-SAP
suggested changes
Aug 18, 2020
...c/main/java/app/coronawarn/server/services/submission/validation/ValidSubmissionPayload.java
Outdated
Show resolved
Hide resolved
modify the Violation text accordingly
pithumke
suggested changes
Aug 20, 2020
.../src/main/java/app/coronawarn/server/services/submission/config/SubmissionServiceConfig.java
Outdated
Show resolved
Hide resolved
...c/main/java/app/coronawarn/server/services/submission/validation/ValidSubmissionPayload.java
Outdated
Show resolved
Hide resolved
...c/main/java/app/coronawarn/server/services/submission/validation/ValidSubmissionPayload.java
Outdated
Show resolved
Hide resolved
...c/main/java/app/coronawarn/server/services/submission/validation/ValidSubmissionPayload.java
Outdated
Show resolved
Hide resolved
...c/main/java/app/coronawarn/server/services/submission/validation/ValidSubmissionPayload.java
Show resolved
Hide resolved
...c/main/java/app/coronawarn/server/services/submission/validation/ValidSubmissionPayload.java
Outdated
Show resolved
Hide resolved
...c/main/java/app/coronawarn/server/services/submission/validation/ValidSubmissionPayload.java
Outdated
Show resolved
Hide resolved
...c/main/java/app/coronawarn/server/services/submission/validation/ValidSubmissionPayload.java
Outdated
Show resolved
Hide resolved
...rc/test/java/app/coronawarn/server/services/submission/controller/PayloadValidationTest.java
Outdated
Show resolved
Hide resolved
...rc/test/java/app/coronawarn/server/services/submission/controller/PayloadValidationTest.java
Outdated
Show resolved
Hide resolved
pithumke
approved these changes
Aug 24, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
EugenM-SAP
approved these changes
Aug 25, 2020
fredrb
added a commit
that referenced
this pull request
Aug 27, 2020
* Revert "Usage of postgres in test environment for database consistency (#686)" (#688) This reverts commit 932a61f. * Mitigate CVE-2020-13935 (#690) * Bump spring parent version * Liveness health indicator according to. spring-projects/spring-boot#22107 * Revert to test postgresql docker image using test-containers. (#694) * Test cases and debug support.for submission (#698) * Add integration test for future submission payload debugging * Added more test cases around invalid temp key parameter scenarios * Add support for printing the submission payload during tests * Enhance debug test with sql statements generation * Update services/submission/src/test/java/app/coronawarn/server/services/submission/integration/SubmissionPersistenceIT.java Co-authored-by: Michael Frey <michael.frey@gmx.ch> Co-authored-by: Hilmar Falkenberg <hilmar.falkenberg@sap.com> Co-authored-by: Michael Frey <michael.frey@gmx.ch> * Update maven.config with current version 1.4.0-SNAPSHOT (#697) Set current version to 1.3.0-SNAPSHOT Co-authored-by: Hilmar Falkenberg <hilmar.falkenberg@sap.com> * -fix invalid test and name refactoring (#703) * Add app-features as external configuration (#704) * Add app features in configuration file Adjust tests * Rename env variable for plausible deniability active. Remove env name for app feature label. * Adjust test application.yaml * Change active type from boolean to integer * Change app feature 'active' property to 'value' * use same version for spring-boot-starter-parent accross all components (#709) * Fix/700 retention policy (#711) * fix retention policy of stored diagnosis keys * fix typo * fix failing test case due to previously injected time * refactor method names * Submission Service - updated documentation (#713) * Updated the validation for the submission service in SUMBISSION.md to match the new rules for TEK's * markdownlint fixes * Update docs/SUBMISSION.md Co-authored-by: Sorin Stefan Iovita <sorin.stefan.iovita@sap.com> Co-authored-by: Ioan Gut <ioan.gut@sap.com> Co-authored-by: ioangut <67064882+ioangut@users.noreply.github.com> Co-authored-by: Sorin Stefan Iovita <sorin.stefan.iovita@sap.com> * Submission Service - Enhance TEK's (#712) * -initial draft commit * updated checkDuplicateStartIntervalNumberLimit wip * updated checkDuplicateStartIntervalNumberLimit * -fix test broke after solved conflict * changed checkDuplicateStartIntervalNumberLimit to use HashMap * -fix checklist reports * add env variables for submission service * review update add more tests * solved code smells * rename attribute maxRollingPeriod * renamed getter getMaxRollingPeriod * Update ValidSubmissionPayload.java * refactor implementation for consistency * fix checkstyle errors modify the Violation text accordingly * fix code smell * Update ValidSubmissionPayload.java * Change validation for payloads based on rolling period * Capture more test scenarios * add checkstyle indentation * create test data generation class * add header to the new class * resolved review conversation * fixed checkstyle errors * resolved code smell * fix compile error * create valid TEK, fix test failing Co-authored-by: Emmet <emmet.power@sap.com> Co-authored-by: Eugen M <eugen.madean@sap.com> Co-authored-by: Pit Humke <pithumke@users.noreply.github.com> * Feature/enrich app config (#726) * Added supported countries to app config with application.yaml parameter * Fixed Test failures * Remove unused code * Added app version parameters to application.yaml * Added tests for app version parameters * Refacted country list implementation Co-authored-by: Hilmar Falkenberg <hilmar.falkenberg@sap.com> * fix errors after merging master * add review fixes * fix code smells reported * build submission payload data added * build SubmissionPayload for tests * add diagnosis key test data time creation * add surefire plugin to common and submission build Co-authored-by: Frederico <fred.rbittencourt@gmail.com> Co-authored-by: Sorin Stefan Iovita <sorin.stefan.iovita@sap.com> Co-authored-by: EugenM-SAP <67458405+EugenM-SAP@users.noreply.github.com> Co-authored-by: Hilmar Falkenberg <hilmar.falkenberg@sap.com> Co-authored-by: Michael Frey <michael.frey@gmx.ch> Co-authored-by: Evgenii Skrebtcov <67064767+EvgeniiSkrebtcov@users.noreply.github.com> Co-authored-by: ioangut <67064882+ioangut@users.noreply.github.com> Co-authored-by: emmetsap <emmet.power@sap.com> Co-authored-by: Ioan Gut <ioan.gut@sap.com> Co-authored-by: Eugen M <eugen.madean@sap.com> Co-authored-by: Pit Humke <pithumke@users.noreply.github.com>
sorin-iovita
pushed a commit
that referenced
this pull request
Sep 15, 2020
* Revert "Usage of postgres in test environment for database consistency (#686)" (#688) This reverts commit 932a61f. * Mitigate CVE-2020-13935 (#690) * Bump spring parent version * Liveness health indicator according to. spring-projects/spring-boot#22107 * Revert to test postgresql docker image using test-containers. (#694) * Test cases and debug support.for submission (#698) * Add integration test for future submission payload debugging * Added more test cases around invalid temp key parameter scenarios * Add support for printing the submission payload during tests * Enhance debug test with sql statements generation * Update services/submission/src/test/java/app/coronawarn/server/services/submission/integration/SubmissionPersistenceIT.java Co-authored-by: Michael Frey <michael.frey@gmx.ch> Co-authored-by: Hilmar Falkenberg <hilmar.falkenberg@sap.com> Co-authored-by: Michael Frey <michael.frey@gmx.ch> * Update maven.config with current version 1.4.0-SNAPSHOT (#697) Set current version to 1.3.0-SNAPSHOT Co-authored-by: Hilmar Falkenberg <hilmar.falkenberg@sap.com> * -fix invalid test and name refactoring (#703) * Add app-features as external configuration (#704) * Add app features in configuration file Adjust tests * Rename env variable for plausible deniability active. Remove env name for app feature label. * Adjust test application.yaml * Change active type from boolean to integer * Change app feature 'active' property to 'value' * use same version for spring-boot-starter-parent accross all components (#709) * Fix/700 retention policy (#711) * fix retention policy of stored diagnosis keys * fix typo * fix failing test case due to previously injected time * refactor method names * Submission Service - updated documentation (#713) * Updated the validation for the submission service in SUMBISSION.md to match the new rules for TEK's * markdownlint fixes * Update docs/SUBMISSION.md Co-authored-by: Sorin Stefan Iovita <sorin.stefan.iovita@sap.com> Co-authored-by: Ioan Gut <ioan.gut@sap.com> Co-authored-by: ioangut <67064882+ioangut@users.noreply.github.com> Co-authored-by: Sorin Stefan Iovita <sorin.stefan.iovita@sap.com> * Submission Service - Enhance TEK's (#712) * -initial draft commit * updated checkDuplicateStartIntervalNumberLimit wip * updated checkDuplicateStartIntervalNumberLimit * -fix test broke after solved conflict * changed checkDuplicateStartIntervalNumberLimit to use HashMap * -fix checklist reports * add env variables for submission service * review update add more tests * solved code smells * rename attribute maxRollingPeriod * renamed getter getMaxRollingPeriod * Update ValidSubmissionPayload.java * refactor implementation for consistency * fix checkstyle errors modify the Violation text accordingly * fix code smell * Update ValidSubmissionPayload.java * Change validation for payloads based on rolling period * Capture more test scenarios * add checkstyle indentation * create test data generation class * add header to the new class * resolved review conversation * fixed checkstyle errors * resolved code smell * fix compile error * create valid TEK, fix test failing Co-authored-by: Emmet <emmet.power@sap.com> Co-authored-by: Eugen M <eugen.madean@sap.com> Co-authored-by: Pit Humke <pithumke@users.noreply.github.com> * Feature/enrich app config (#726) * Added supported countries to app config with application.yaml parameter * Fixed Test failures * Remove unused code * Added app version parameters to application.yaml * Added tests for app version parameters * Refacted country list implementation Co-authored-by: Hilmar Falkenberg <hilmar.falkenberg@sap.com> * Fix Sonar issues (#754) * Bugfix/submission tek rolling period (#752) * Replaced possible variable rolling period with constant value * Add tests for flexible rolling period * apply sugested review changes * Add javaDoc comments for changed getExpiryDateTime * Fix midnight check in SubmissionPayload Validator Co-authored-by: Michael Burwig <michael.burwig@sap.com> * Feature/update risk score master (#758) * Update risk-score-classification.yaml Problem in iOS 13.7 --> Unbekanntes Risiko bei Risikobegegnung * Adjust tests Co-authored-by: Hilmar Falkenberg <hilmar.falkenberg@sap.com> Co-authored-by: Michael Burwig <michael.burwig@sap.com> * Update exposure-config.yaml (#765) patch transmission as requested by Thomas Augsten Co-authored-by: Hilmar Falkenberg <hilmar.falkenberg@sap.com> * Resolve merge conflicts * Resolve github comments Co-authored-by: Frederico <fred.rbittencourt@gmail.com> Co-authored-by: EugenM-SAP <67458405+EugenM-SAP@users.noreply.github.com> Co-authored-by: Hilmar Falkenberg <hilmar.falkenberg@sap.com> Co-authored-by: Michael Frey <michael.frey@gmx.ch> Co-authored-by: Evgenii Skrebtcov <67064767+EvgeniiSkrebtcov@users.noreply.github.com> Co-authored-by: ioangut <67064882+ioangut@users.noreply.github.com> Co-authored-by: emmetsap <emmet.power@sap.com> Co-authored-by: Ioan Gut <ioan.gut@sap.com> Co-authored-by: Eugen M <eugen.madean@sap.com> Co-authored-by: Pit Humke <pithumke@users.noreply.github.com> Co-authored-by: KevponSAP <66735382+KevponSAP@users.noreply.github.com> Co-authored-by: Michael Burwig <michael.burwig@sap.com>
hilmarf
added a commit
that referenced
this pull request
Oct 1, 2020
* Revert "Usage of postgres in test environment for database consistency (#686)" (#688) This reverts commit 932a61f. * Mitigate CVE-2020-13935 (#690) * Bump spring parent version * Liveness health indicator according to. spring-projects/spring-boot#22107 * Revert to test postgresql docker image using test-containers. (#694) * Test cases and debug support.for submission (#698) * Add integration test for future submission payload debugging * Added more test cases around invalid temp key parameter scenarios * Add support for printing the submission payload during tests * Enhance debug test with sql statements generation * Update services/submission/src/test/java/app/coronawarn/server/services/submission/integration/SubmissionPersistenceIT.java Co-authored-by: Michael Frey <michael.frey@gmx.ch> Co-authored-by: Hilmar Falkenberg <hilmar.falkenberg@sap.com> Co-authored-by: Michael Frey <michael.frey@gmx.ch> * Update maven.config with current version 1.4.0-SNAPSHOT (#697) Set current version to 1.3.0-SNAPSHOT Co-authored-by: Hilmar Falkenberg <hilmar.falkenberg@sap.com> * -fix invalid test and name refactoring (#703) * Add app-features as external configuration (#704) * Add app features in configuration file Adjust tests * Rename env variable for plausible deniability active. Remove env name for app feature label. * Adjust test application.yaml * Change active type from boolean to integer * Change app feature 'active' property to 'value' * use same version for spring-boot-starter-parent accross all components (#709) * Fix/700 retention policy (#711) * fix retention policy of stored diagnosis keys * fix typo * fix failing test case due to previously injected time * refactor method names * Submission Service - updated documentation (#713) * Updated the validation for the submission service in SUMBISSION.md to match the new rules for TEK's * markdownlint fixes * Update docs/SUBMISSION.md Co-authored-by: Sorin Stefan Iovita <sorin.stefan.iovita@sap.com> Co-authored-by: Ioan Gut <ioan.gut@sap.com> Co-authored-by: ioangut <67064882+ioangut@users.noreply.github.com> Co-authored-by: Sorin Stefan Iovita <sorin.stefan.iovita@sap.com> * Submission Service - Enhance TEK's (#712) * -initial draft commit * updated checkDuplicateStartIntervalNumberLimit wip * updated checkDuplicateStartIntervalNumberLimit * -fix test broke after solved conflict * changed checkDuplicateStartIntervalNumberLimit to use HashMap * -fix checklist reports * add env variables for submission service * review update add more tests * solved code smells * rename attribute maxRollingPeriod * renamed getter getMaxRollingPeriod * Update ValidSubmissionPayload.java * refactor implementation for consistency * fix checkstyle errors modify the Violation text accordingly * fix code smell * Update ValidSubmissionPayload.java * Change validation for payloads based on rolling period * Capture more test scenarios * add checkstyle indentation * create test data generation class * add header to the new class * resolved review conversation * fixed checkstyle errors * resolved code smell * fix compile error * create valid TEK, fix test failing Co-authored-by: Emmet <emmet.power@sap.com> Co-authored-by: Eugen M <eugen.madean@sap.com> Co-authored-by: Pit Humke <pithumke@users.noreply.github.com> * Feature/enrich app config (#726) * Added supported countries to app config with application.yaml parameter * Fixed Test failures * Remove unused code * Added app version parameters to application.yaml * Added tests for app version parameters * Refacted country list implementation Co-authored-by: Hilmar Falkenberg <hilmar.falkenberg@sap.com> * Fix Sonar issues (#754) * Bugfix/submission tek rolling period (#752) * Replaced possible variable rolling period with constant value * Add tests for flexible rolling period * apply sugested review changes * Add javaDoc comments for changed getExpiryDateTime * Fix midnight check in SubmissionPayload Validator Co-authored-by: Michael Burwig <michael.burwig@sap.com> * Feature/update risk score master (#758) * Update risk-score-classification.yaml Problem in iOS 13.7 --> Unbekanntes Risiko bei Risikobegegnung * Adjust tests Co-authored-by: Hilmar Falkenberg <hilmar.falkenberg@sap.com> Co-authored-by: Michael Burwig <michael.burwig@sap.com> * Update exposure-config.yaml (#765) patch transmission as requested by Thomas Augsten Co-authored-by: Hilmar Falkenberg <hilmar.falkenberg@sap.com> * Update attenuation-duration.yaml (#775) (#776) * Update attenuation-duration.yaml * Update exposure-config.yaml attenuation array = 2 Co-authored-by: Hilmar Falkenberg <hilmar.falkenberg@sap.com> * prepare release 1.5.0 (#793) * Fix sping web guava (#808) * RC 1.4.0 * mitigate CVE-2020-5421 by switching to newer spring-boot-starter-parent (#796) * Release/1.4 log submission keys (#797) * Implement the changes from PR #783 * Add check and logs for missing key with TRL 6 or having a key TRL 6 from today midnight * Fix code smell * ensure usage of latest guava version 29.0-jre (#806) Co-authored-by: Michael <66735191+mibrasap@users.noreply.github.com> * Update CODEOWNERS file (#817) * Admin/update codeowners (#818) * Update CODEOWNERS file * Add additional team members to codeowners file Co-authored-by: Michael Burwig <michael.burwig@sap.com> * Add hot fix for submission payload validation (#822) (#825) * Add hot fix for submission payload validation (#822) * Fixed code smell * fix branch after merge conflicts * Adjustments after code review * removed unused getExpiryDateTime method * removed unused import code smell * Adjust submission payload validation checks in Master(#832) f (#834) * Adjust submission payload validation checks (#832) * remove unused import code smell * Removed unused duplicated methods Co-authored-by: Frederico <fred.rbittencourt@gmail.com> Co-authored-by: Sorin Stefan Iovita <sorin.stefan.iovita@sap.com> Co-authored-by: EugenM-SAP <67458405+EugenM-SAP@users.noreply.github.com> Co-authored-by: Hilmar Falkenberg <hilmar.falkenberg@sap.com> Co-authored-by: Michael Frey <michael.frey@gmx.ch> Co-authored-by: Evgenii Skrebtcov <67064767+EvgeniiSkrebtcov@users.noreply.github.com> Co-authored-by: emmetsap <emmet.power@sap.com> Co-authored-by: Eugen M <eugen.madean@sap.com> Co-authored-by: Pit Humke <pithumke@users.noreply.github.com> Co-authored-by: KevponSAP <66735382+KevponSAP@users.noreply.github.com> Co-authored-by: Michael Burwig <michael.burwig@sap.com> Co-authored-by: Michael <66735191+mibrasap@users.noreply.github.com> Co-authored-by: Michael Burwig <64439292+michael-burwig@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description