Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

create VerificationPortalErrorControllerTest #102

Merged
merged 2 commits into from
Jan 27, 2021
Merged

create VerificationPortalErrorControllerTest #102

merged 2 commits into from
Jan 27, 2021

Conversation

Ra-Jo-cosee
Copy link
Contributor

The VerificationPortalErrorController had no tests, so we created some.

@daniel-eder daniel-eder added the in review Moderators are investigating how to best proceed with the issue label Sep 28, 2020
@daniel-eder daniel-eder added icebox An issue or PR that has been postponed indefinitely and removed in review Moderators are investigating how to best proceed with the issue labels Oct 8, 2020
@daniel-eder
Copy link
Member

As the CWA is already in production use we focus our resources only on critical issues and PRs, therefore I placed this in the icebox for now. If you feel that this is unwarranted, please let us know why you believe this qualifies as high priority.

@Ra-Jo-cosee
Copy link
Contributor Author

Hi,
thanks for your reply.
We think a high test coverage is desirable and can help to maintain code quality. Since VerificationPortalErrorController is a public facing controller we think it should have at least some test coverage, for example to help prevent regressions.
However we totally understand that you might want to focus your work elsewhere or can't prioritize this right now.

Kind regards

@mschulte-tsi mschulte-tsi self-requested a review as a code owner January 27, 2021 12:52
mschulte-tsi
mschulte-tsi approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@mschulte-tsi mschulte-tsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution

@mschulte-tsi mschulte-tsi merged commit 641ce49 into corona-warn-app:master Jan 27, 2021
@ascheibal ascheibal added enhancement New feature or request and removed icebox An issue or PR that has been postponed indefinitely labels Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mschulte-tsi mschulte-tsi mschulte-tsi approved these changes

@alstiefel alstiefel Awaiting requested review from alstiefel

@ascheibal ascheibal Awaiting requested review from ascheibal

@ChristianFirmenich ChristianFirmenich Awaiting requested review from ChristianFirmenich

@dfischer-tech dfischer-tech Awaiting requested review from dfischer-tech

@f11h f11h Awaiting requested review from f11h

@jhagestedt jhagestedt Awaiting requested review from jhagestedt

@kreincke kreincke Awaiting requested review from kreincke

@lbenthins lbenthins Awaiting requested review from lbenthins

@mlaue-tech-zz mlaue-tech-zz Awaiting requested review from mlaue-tech-zz

@tence tence Awaiting requested review from tence

Assignees

@ascheibal ascheibal

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ra-Jo-cosee @daniel-eder @mschulte-tsi @ascheibal