Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance adapt actions upload&download to v4 #683

Merged
merged 1 commit into from Mar 14, 2024

Conversation

clang-clang-clang
Copy link
Contributor

@clang-clang-clang clang-clang-clang commented Mar 13, 2024

Supplementary submission of #681.

Rechecked the update content and found that download-artifact no longer creates a directory for artifacts by default.

Also checked the changes currently in use but compatible content:

  • actions/checkout v3 → v4
    • ommit params
    • submodules
    • repository and path
  • actions/download-artifact v1, v2 → v4
    • v4 can only download artifacts created by upload v4 and above.
    • If the name input parameter is not provided, all artifacts will be downloaded.
    • make a different name and filter the downloads, merge-multiple (Have matched scenario but achieve with other methods)
  • actions/upload-artifact v1, v2 → v4
    • no multiple jobs upload to the same Artifact, no overwrite.

@clang-clang-clang
Copy link
Contributor Author

Sorry for the oversight, this should be able to run Action now, please try the daily build. @Shchvova

@Shchvova
Copy link
Contributor

No worries. It had to be done sooner or later. Thank you so much for the undertaking.

@Shchvova Shchvova merged commit fbd117c into coronalabs:master Mar 14, 2024
1 check passed
@clang-clang-clang clang-clang-clang deleted the try-fix-action branch March 14, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants