Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ayushma: Add Feedback #75

Closed
shivankacker opened this issue Apr 27, 2023 · 4 comments · Fixed by #194 or ohcnetwork/ayushma_fe#54
Closed

Ayushma: Add Feedback #75

shivankacker opened this issue Apr 27, 2023 · 4 comments · Fixed by #194 or ohcnetwork/ayushma_fe#54
Assignees
Labels

Comments

@shivankacker
Copy link
Member

Users should be able to provide feedback to the chat.
This should be handled by a Feedback model, which has

  • chat_message : fk to ChatMessage
  • user : fk to User
  • liked : boolean
  • message : (optional) text

Make relevant views and serializers. Feedback should be listed with /feedback url, with possible filters -

  • project_id
  • chat_id
  • chat_message_id
  • liked

Only admins should be able to list and retrieve all feedback. Normal users can only list their own. Feedbacks cannot be deleted.

@khavinshankar khavinshankar self-assigned this May 29, 2023
@khavinshankar
Copy link
Member

Hey @skks1212, I have a couple of questions,

  1. In the above description, you mentioned adding user_id as a foreign key, but as the chat itself is user-specific, do we need that? 🤔
    image

  2. Second is more like clarification, we should also have thumbs down, right? And as far as storing value goes, liked === null, no feedback; liked === true, thumbs up; and liked === false, thumbs down;

@shivankacker
Copy link
Member Author

Hey @khavinshankar yes we can leave out the user field.
And as liked is Boolean, thumbs-up will be ===true and thumbs down will be ===false. It will be a not null field

@khavinshankar
Copy link
Member

Hey @skks1212, about /feedback endpoint, is just an endpoint enough or do we need a dedicated screen in the frontend, if so where?

@shivankacker
Copy link
Member Author

@khavinshankar we need the feedback buttons on the chat UI (👍,👎) and a way to list feedbacks in the admin panel, preferably in its own page

@gigincg gigincg changed the title Add Feedback Ayushma: Add Feedback Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants