Fixed cancel and update profile buttons moving on /profile url. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shivankacker
requested changes
Jun 20, 2023
src/app/(main)/profile/page.tsx
Outdated
| <p className="text text-sm text-red-500 mb-2"> | ||
| Passwords do not match | ||
| </p> | ||
| ) : ( | ||
| <p className="text-transparent text-sm mb-2">Hidden Text</p> |
There was a problem hiding this comment.
Suggested change
| <p className="text-transparent text-sm mb-2">Hidden Text</p> | |
| <p className="text-transparent text-sm mb-2"> </p> |
Text can still be highlighted : )
|
Fixed, text can't be highlighted now. |
shivankacker
approved these changes
Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed: #39
What was solved:
The buttons were moving when the password and confirm password weren't matching.
How was it solved:
I added a dummy invisible text to replace the passwords don't match text. So the new text takes up space and wouldn't let the buttons move above.
References:
Before:
https://github.com/coronasafe/ayushma_fe/assets/73941119/8058fc59-856c-42a5-bc00-c76cb0327359
After/ Proposed Changes:
https://github.com/coronasafe/ayushma_fe/assets/73941119/dcbba38a-efd5-44ef-8970-1a8009ba69ce