Fix Unit Tests

[vigneshhari]

All Unit Tests are broken, we need better unit testing with more edge cases on core functionality including permission scoping tests.

[issue-label-bot]

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.87. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[millefalcon]

Hello, i would like to try this out. Any pointers on where i should get started ?

[vigneshhari]

Hi, we have a lot of breaking unit tests, you can start with those, and then later on we can write more unit tests and check more edge cases.

[millefalcon]

Sure. I am bit confused about where these users and facilities are created. Or are they created using some sample data. Is there any get started guide i could look at ? Apologies for the noob question. This is what i see, after i have run the dev (i changed the config a bit for it find the static files) server.

[vigneshhari]

You can send an email at vichuhari100@gmail.com and we can schedule a call to explain the code a bit.

[millefalcon]

Sure. Thanks :)

[millefalcon]

So, i started going through some tests, and for one of the test for ex: care.facility.tests.test_patient_sample_api.TestPatientSampleApi, i found that the facility is not bound with the patient hence the patients failcity attribute become None and it fails the test with AttributeError: 'NoneType' object has no attribute 'external_id'.

...
 def get_sample_data(self, **kwargs):
        patient = kwargs.get("patient", self.patient)
        consultation = kwargs.get("consultation", self.consultation)
        return {
            "patient": str(patient.external_id),
            "consultation": str(consultation.external_id),
            "sample_type": "BA/ETA",
            "testing_facility": str(patient.facility.external_id),
        }
...

Should that been "testing_facility": str(consulation.facility.external_id), instead of "testing_facility": str(patient.facility.external_id),. I think, i need to read through once more :)

How should one handle this ? Any thoughts ?

[sainak]

Closing in favour of #794