Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store review_interval and use it to compute next review_time #1042

Merged
merged 2 commits into from
Oct 12, 2022

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Sep 29, 2022

Proposed Changes

This PR should not conflict any existing records, all it does is create a new field, which stores the minutes before the next review is to happen. Earlier this value was not stored at all and was just used to compute the review_time.

image

@coronasafe/code-reviewers

@Ashesh3 Ashesh3 requested a review from a team as a code owner September 29, 2022 15:24
@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Ashesh3
Copy link
Member Author

Ashesh3 commented Oct 10, 2022

@vigneshhari Any updates on this?

@vigneshhari vigneshhari merged commit d49d446 into coronasafe:master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants