Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates consultation's category from daily_round's patient_category #1045

Closed
wants to merge 2 commits into from

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented Sep 30, 2022

Proposed Changes

  • Updates consultation category from daily_round patient_category

Associated Issue

@coronasafe/code-reviewers

@aeswibon aeswibon requested a review from a team as a code owner September 30, 2022 12:43
@sonarcloud
Copy link

sonarcloud bot commented Sep 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gigincg
Copy link
Member

gigincg commented Nov 17, 2022

@vigneshhari LGTM, Can we merge?

@sonarcloud
Copy link

sonarcloud bot commented Apr 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.6% 0.6% Duplication

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (5b13720) 56.22% compared to head (b303a98) 56.20%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1045      +/-   ##
==========================================
- Coverage   56.22%   56.20%   -0.02%     
==========================================
  Files         193      193              
  Lines        9491     9493       +2     
  Branches     1600     1600              
==========================================
  Hits         5336     5336              
- Misses       4100     4102       +2     
  Partials       55       55              
Impacted Files Coverage Δ
care/facility/api/serializers/daily_round.py 33.33% <0.00%> (-0.45%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gigincg
Copy link
Member

gigincg commented Apr 6, 2023

This is unnecessary, the data is already present in consultaiton.last_daily_round

@gigincg gigincg closed this Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants