Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Issue in bed option in consultation form #1048

Closed
wants to merge 3 commits into from

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented Oct 2, 2022

Updates

* Removed use of consultation bed model to create new records
* Added serializer to create/update consultation bed records
* Reformatted the code
* Removed unused imports
* Updated more fields of consultation form during new consultation bed
* Reformatted the code
@aeswibon aeswibon requested a review from a team as a code owner October 2, 2022 15:02
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2022

Codecov Report

Base: 56.08% // Head: 56.04% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (e13e021) compared to base (8cbb1c6).
Patch coverage: 28.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1048      +/-   ##
==========================================
- Coverage   56.08%   56.04%   -0.05%     
==========================================
  Files         175      175              
  Lines        8616     8624       +8     
  Branches     1460     1476      +16     
==========================================
+ Hits         4832     4833       +1     
- Misses       3732     3739       +7     
  Partials       52       52              
Impacted Files Coverage Δ
care/facility/api/serializers/bed.py 40.17% <0.00%> (-1.06%) ⬇️
...e/facility/api/serializers/patient_consultation.py 33.33% <33.33%> (-0.76%) ⬇️
care/users/api/viewsets/change_password.py 61.53% <0.00%> (+1.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aeswibon aeswibon closed this Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants