Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds facility s3 region code #1053

Merged

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Oct 6, 2022

Adds Region code defaulting to ap-south-1

@rithviknishad rithviknishad requested a review from a team as a code owner October 6, 2022 14:18
@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Base: 56.08% // Head: 56.09% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (6a17ed9) compared to base (e7052a9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1053      +/-   ##
==========================================
+ Coverage   56.08%   56.09%   +0.01%     
==========================================
  Files         175      175              
  Lines        8617     8619       +2     
  Branches     1460     1475      +15     
==========================================
+ Hits         4833     4835       +2     
  Misses       3732     3732              
  Partials       52       52              
Impacted Files Coverage Δ
config/settings/base.py 90.71% <100.00%> (+0.06%) ⬆️
care/users/api/viewsets/change_password.py 61.53% <0.00%> (+1.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vigneshhari vigneshhari merged commit 0e257a6 into coronasafe:master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants