-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds archive_reason
to FileUpload
and validate if is_archived
#1055
Adds archive_reason
to FileUpload
and validate if is_archived
#1055
Conversation
Codecov ReportBase: 56.09% // Head: 56.07% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1055 +/- ##
==========================================
- Coverage 56.09% 56.07% -0.03%
==========================================
Files 175 175
Lines 8618 8630 +12
Branches 1460 1477 +17
==========================================
+ Hits 4834 4839 +5
- Misses 3732 3739 +7
Partials 52 52
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
archive_reason
to FileUpload
and validate if is_archived
We should also not let them update the archive reason. I believe that was the conclusion from the last call with @aparnacoronasafe , Do confirm before you make this change. |
I agree with vig |
@vigneshhari I've pushed the changes required. |
Kudos, SonarCloud Quality Gate passed!
|
Closes #1054
Required by coronasafe/care_fe#3366
Proposed Changes
archive_reason
archive_reason
to be mandatory ifis_archived
is set.@coronasafe/code-reviewers
Merge Checklist
/docs