Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: Permission Error during Facility Delete #1059

Closed
wants to merge 1 commit into from

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented Oct 9, 2022

Proposed Changes

  • Updated the has_object_destroy_permission method for permission checking

Associated Issue

@coronasafe/code-reviewers

@codecov-commenter
Copy link

Codecov Report

Base: 56.06% // Head: 56.04% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (8933d12) compared to base (0beaa72).
Patch coverage: 25.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1059      +/-   ##
==========================================
- Coverage   56.06%   56.04%   -0.03%     
==========================================
  Files         175      175              
  Lines        8629     8638       +9     
  Branches     1462     1477      +15     
==========================================
+ Hits         4838     4841       +3     
- Misses       3739     3745       +6     
  Partials       52       52              
Impacted Files Coverage Δ
...are/facility/models/mixins/permissions/facility.py 47.45% <25.00%> (-3.53%) ⬇️
care/users/api/viewsets/change_password.py 61.53% <0.00%> (+1.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

@vigneshhari can you review it

@aeswibon aeswibon closed this Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants