Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor home_facility to home_facility_obj #1114

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Dec 1, 2022

Required for coronasafe/care_fe#4177
Related Issue: coronasafe/care_fe#4150

  • Refactor home_facility to home_facility_object

@coronasafe/code-reviewers

@sonarcloud
Copy link

sonarcloud bot commented Dec 1, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
7.3% 7.3% Duplication

@codecov-commenter
Copy link

Codecov Report

Base: 55.90% // Head: 55.90% // No change to project coverage 👍

Coverage data is based on head (c88171c) compared to base (46c64c3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1114   +/-   ##
=======================================
  Coverage   55.90%   55.90%           
=======================================
  Files         175      175           
  Lines        8713     8713           
  Branches     1490     1490           
=======================================
  Hits         4871     4871           
- Misses       3787     3790    +3     
+ Partials       55       52    -3     
Impacted Files Coverage Δ
care/users/api/serializers/user.py 61.59% <100.00%> (ø)
care/users/management/commands/load_ward_data.py 0.00% <0.00%> (ø)
...are/facility/api/viewsets/patient_investigation.py 52.60% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gigincg gigincg merged commit 87dc216 into coronasafe:master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants