Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABDM M1 #1117

Merged
merged 7 commits into from
Jul 21, 2023
Merged

ABDM M1 #1117

merged 7 commits into from
Jul 21, 2023

Conversation

gigincg
Copy link
Member

@gigincg gigincg commented Dec 12, 2022

Proposed Changes

  • Change 1
  • Change 2

Associated Issue

Architecture changes

@coronasafe/code-reviewers

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@gigincg gigincg requested a review from a team as a code owner December 12, 2022 16:15
@codecov-commenter
Copy link

Codecov Report

Base: 55.70% // Head: 55.29% // Decreases project coverage by -0.41% ⚠️

Coverage data is based on head (d7cd31b) compared to base (a08182c).
Patch coverage: 41.12% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1117      +/-   ##
==========================================
- Coverage   55.70%   55.29%   -0.42%     
==========================================
  Files         177      182       +5     
  Lines        8757     8998     +241     
  Branches     1501     1522      +21     
==========================================
+ Hits         4878     4975      +97     
- Misses       3827     3971     +144     
  Partials       52       52              
Impacted Files Coverage Δ
care/abdm/apps.py 0.00% <0.00%> (ø)
care/utils/assetintegration/onvif.py 38.23% <ø> (ø)
care/abdm/utils/api_call.py 26.88% <26.88%> (ø)
care/abdm/api/viewsets/healthid.py 38.04% <38.04%> (ø)
care/abdm/models.py 93.33% <93.33%> (ø)
care/abdm/api/serializers/healthid.py 100.00% <100.00%> (ø)
care/facility/models/patient.py 92.91% <100.00%> (+0.05%) ⬆️
config/api_router.py 98.07% <100.00%> (+0.03%) ⬆️
config/settings/base.py 90.84% <100.00%> (+0.13%) ⬆️
care/facility/api/serializers/file_upload.py 42.27% <0.00%> (-1.43%) ⬇️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

data_json = json.dumps(data)
# print("curl -X POST {} {} -d {}".format(url, headers_string, data_json))
print("Posting Request to: {}".format(url))
response = requests.post(url, headers=headers, data=data_json, verify=False)

Check failure

Code scanning / SonarCloud

Server certificates should be verified during SSL/TLS connections

<!--SONAR_ISSUE_KEY:AYVxnnKhNGUvOf4UX1lL-->Enable server certificate validation on this SSL/TLS connection. <p>See more on <a href="https://sonarcloud.io/project/issues?id=coronasafe_care&issues=AYVxnnKhNGUvOf4UX1lL&open=AYVxnnKhNGUvOf4UX1lL&pullRequest=1117">SonarCloud</a></p>
url = self.url + path
headers = {}
headers = self.add_auth_header(headers)
response = requests.get(url, headers=headers, params=params, verify=False)

Check failure

Code scanning / SonarCloud

Server certificates should be verified during SSL/TLS connections

<!--SONAR_ISSUE_KEY:AYVxnnKhNGUvOf4UX1lK-->Enable server certificate validation on this SSL/TLS connection. <p>See more on <a href="https://sonarcloud.io/project/issues?id=coronasafe_care&issues=AYVxnnKhNGUvOf4UX1lK&open=AYVxnnKhNGUvOf4UX1lK&pullRequest=1117">SonarCloud</a></p>
ABDM_TOKEN_URL,
data=json.dumps(data),
headers=auth_headers,
verify=False,

Check failure

Code scanning / SonarCloud

Server certificates should be verified during SSL/TLS connections

<!--SONAR_ISSUE_KEY:AYVxnnKhNGUvOf4UX1lJ-->Enable server certificate validation on this SSL/TLS connection. <p>See more on <a href="https://sonarcloud.io/project/issues?id=coronasafe_care&issues=AYVxnnKhNGUvOf4UX1lJ&open=AYVxnnKhNGUvOf4UX1lJ&pullRequest=1117">SonarCloud</a></p>
@sonarcloud
Copy link

sonarcloud bot commented Jan 2, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability D 3 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mathew-alex mathew-alex merged commit e80d843 into master Jul 21, 2023
@mathew-alex mathew-alex deleted the abdm-m1 branch July 21, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants