Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Documentation for delete_facility endpoint for users #1138

Merged
merged 1 commit into from
Dec 28, 2022

Conversation

aeswibon
Copy link
Member

Bug Fix

Proposed Change

  • Updated swagger schema by adding request_body to the endpoint

Associated Issue

Screenshot

image

@coronasafe/code-reviewers

Merge CheckList

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@aeswibon aeswibon requested a review from a team as a code owner December 25, 2022 09:35
@sonarcloud
Copy link

sonarcloud bot commented Dec 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Base: 55.66% // Head: 55.67% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (b6cf1c9) compared to base (8cf80f3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1138      +/-   ##
==========================================
+ Coverage   55.66%   55.67%   +0.01%     
==========================================
  Files         177      177              
  Lines        8769     8772       +3     
  Branches     1505     1505              
==========================================
+ Hits         4881     4884       +3     
  Misses       3836     3836              
  Partials       52       52              
Impacted Files Coverage Δ
care/users/api/viewsets/users.py 54.26% <100.00%> (+0.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vigneshhari vigneshhari merged commit 4bace6e into coronasafe:master Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation misleading in a few places
3 participants