Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add a consultation_status field in consultation model #1143

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented Jan 4, 2023

Feature Request

Proposed Changes

  • Added a consultation_status field of type IntegerField in consultation model

Associated Issue

Architecture changes

  • N/A

@coronasafe/code-reviewers

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@aeswibon aeswibon requested a review from a team as a code owner January 4, 2023 11:32
@nihal467 nihal467 added the P1 High priority; urgent label Jan 10, 2023
@nihal467
Copy link
Member

@cp-Coder what is the status of this PR

@sonarcloud
Copy link

sonarcloud bot commented Jan 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Base: 55.66% // Head: 55.58% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (a113fc6) compared to base (51b7899).
Patch coverage: 32.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1143      +/-   ##
==========================================
- Coverage   55.66%   55.58%   -0.08%     
==========================================
  Files         177      177              
  Lines        8776     8812      +36     
  Branches     1506     1515       +9     
==========================================
+ Hits         4885     4898      +13     
- Misses       3839     3862      +23     
  Partials       52       52              
Impacted Files Coverage Δ
care/facility/api/viewsets/patient.py 45.57% <0.00%> (-2.86%) ⬇️
config/authentication.py 34.56% <0.00%> (+0.42%) ⬆️
care/facility/api/serializers/facility.py 76.81% <14.28%> (-7.06%) ⬇️
care/facility/models/patient_base.py 100.00% <100.00%> (ø)
care/facility/models/patient_consultation.py 95.58% <100.00%> (+0.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nihal467
Copy link
Member

@vigneshhari @gigincg can you review it

@gigincg gigincg merged commit c4f0963 into coronasafe:master Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority; urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a consultation status field in consultation model
5 participants