Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom page_size for different pages #1147

Closed
wants to merge 1 commit into from

Conversation

Pranshu1902
Copy link
Contributor

Fixes #1146
Added custom pagination page_size limit for Patients, Users, and Assets page.

@Pranshu1902 Pranshu1902 requested a review from a team as a code owner January 7, 2023 11:44
@sonarcloud
Copy link

sonarcloud bot commented Jan 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Base: 55.68% // Head: 55.69% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (cc810ea) compared to base (382346a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1147      +/-   ##
==========================================
+ Coverage   55.68%   55.69%   +0.01%     
==========================================
  Files         177      177              
  Lines        8773     8776       +3     
  Branches     1505     1505              
==========================================
+ Hits         4885     4888       +3     
  Misses       3836     3836              
  Partials       52       52              
Impacted Files Coverage Δ
care/facility/api/viewsets/asset.py 55.36% <100.00%> (+0.25%) ⬆️
care/facility/api/viewsets/patient.py 48.61% <100.00%> (+0.17%) ⬆️
care/users/api/viewsets/users.py 54.54% <100.00%> (+0.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Pranshu1902
Copy link
Contributor Author

Waiting for changes in care_fe to allow the dispatch of queryparams to the backend.

@Pranshu1902
Copy link
Contributor Author

Bug resolved, error was in front-end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow custom page limit for different pages
2 participants