Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asset class to Asset filters #1158

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Jan 14, 2023

Proposed Changes

Add asset_class to AssetFilter

Associated Pulls/Issues

@coronasafe/code-reviewers

@sonarcloud
Copy link

sonarcloud bot commented Jan 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2023

Codecov Report

Base: 55.53% // Head: 55.53% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (23562a0) compared to base (1d83e1f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1158   +/-   ##
=======================================
  Coverage   55.53%   55.53%           
=======================================
  Files         177      177           
  Lines        8802     8803    +1     
  Branches     1513     1513           
=======================================
+ Hits         4888     4889    +1     
  Misses       3862     3862           
  Partials       52       52           
Impacted Files Coverage Δ
care/facility/api/viewsets/asset.py 55.36% <100.00%> (+0.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

care/utils/assetintegration/onvif.py Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jan 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vigneshhari vigneshhari merged commit c58967f into coronasafe:master Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants