New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix symptomatic_international_traveller crash #1175

Merged

vigneshhari merged 2 commits into coronasafe:master from Ashesh3:fix-symptomatic_international_traveller

Feb 4, 2023

Member

Ashesh3 commented Feb 3, 2023

Proposed Changes

On the ICMR Specimen Referral, the api call to .../icmr_sample errors out with the following error:

TypeError at /api/v1/patient/7c1d2896-8ebf-45c7-b507-98fcedd48ef3/test_sample/5aef7a72-5e2c-4a0f-b689-747aae8b0dce/icmr_sample/
object of type 'NoneType' has no len()

This is because we are calling len(self.patient.countries_travelled) when self.patient.countries_travelled is None. This PR addresses this issue by adding a check for self.patient.countries_travelled to be defined before calling len on it.

@coronasafe/code-reviewers

Ashesh3 added 2 commits

February 3, 2023 14:44


          Fix symptomatic_international_traveller crash

4ed330e


          lint

ea816b0

Ashesh3 requested a review from a team as a code owner

February 3, 2023 09:23

Ashesh3 added the waiting-for-review label

sonarcloud bot commented Feb 3, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

Ashesh3 mentioned this pull request

Fix inconsistent type of visited countries attribute coronasafe/care_fe#2536

Merged

vigneshhari approved these changes

View reviewed changes

vigneshhari merged commit 84879ff into coronasafe:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment