Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qr_code_id to AssetTransactionFilter #1206

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Feb 27, 2023

Proposed Changes

  • Allow user to filter Asset Transactions using either qr_code_id or external_id or both.

Associated Issue

@coronasafe/code-reviewers

@sonarcloud
Copy link

sonarcloud bot commented Feb 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Base: 56.20% // Head: 56.21% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (a15a6be) compared to base (3105155).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1206   +/-   ##
=======================================
  Coverage   56.20%   56.21%           
=======================================
  Files         174      174           
  Lines        8812     8813    +1     
  Branches     1521     1521           
=======================================
+ Hits         4953     4954    +1     
  Misses       3805     3805           
  Partials       54       54           
Impacted Files Coverage Δ
care/facility/api/viewsets/asset.py 55.61% <100.00%> (+0.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vigneshhari vigneshhari merged commit f783ecd into coronasafe:master Mar 3, 2023
Ashesh3 added a commit to Ashesh3/care that referenced this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants