Clone specific fields for 'Normal' type daily rounds #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #1212 +/- ##
==========================================
- Coverage 56.20% 56.12% -0.08%
==========================================
Files 174 174
Lines 8812 8826 +14
Branches 1521 1525 +4
==========================================
+ Hits 4953 4954 +1
- Misses 3805 3818 +13
Partials 54 54
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@vigneshhari @gigincg @khavinshankar can you review this PR ASAP |
vigneshhari
approved these changes
Mar 9, 2023
Ashesh3
added a commit
to Ashesh3/care
that referenced
this pull request
Mar 22, 2023
* Selective copy for normal daily round * Formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes coronasafe/care_fe#5073
Proposed Changes
This PR modifies the
clone_lastfunctionality in theDailyRoundmodel to clone only specific fields when therounds_typeis "Normal". Previously, the entire object was cloned, but this caused issues when certain fields were not applicable to the new round.Associated Issue
@coronasafe/code-reviewers