Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCX Integration #1219

Merged
merged 76 commits into from
Mar 17, 2023
Merged

HCX Integration #1219

merged 76 commits into from
Mar 17, 2023

Conversation

khavinshankar
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2023

Codecov Report

Patch coverage: 57.79% and project coverage change: +0.09 🎉

Comparison is base (53a4a3a) 56.12% compared to head (6642902) 56.22%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1219      +/-   ##
==========================================
+ Coverage   56.12%   56.22%   +0.09%     
==========================================
  Files         174      193      +19     
  Lines        8826     9489     +663     
  Branches     1525     1599      +74     
==========================================
+ Hits         4954     5335     +381     
- Misses       3818     4100     +282     
  Partials       54       54              
Impacted Files Coverage Δ
care/facility/api/serializers/file_upload.py 41.26% <0.00%> (-0.67%) ⬇️
care/hcx/apps.py 0.00% <0.00%> (ø)
care/hcx/static_data/pmjy_packages.py 0.00% <0.00%> (ø)
care/hcx/views.py 0.00% <0.00%> (ø)
config/settings/base.py 90.71% <ø> (ø)
care/facility/tasks/patient/discharge_report.py 29.16% <16.66%> (-8.93%) ⬇️
care/utils/notification_handler.py 16.45% <18.18%> (+0.08%) ⬆️
care/hcx/utils/hcx/__init__.py 25.75% <25.75%> (ø)
care/hcx/api/viewsets/gateway.py 44.31% <44.31%> (ø)
care/hcx/api/viewsets/listener.py 47.27% <47.27%> (ø)
... and 17 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Mar 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@@ -28,6 +28,13 @@ def notification_task_generator(**kwargs):
NotificationGenerator(**kwargs).generate()


@celery.task()
def send_webpush(**kwargs):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vigneshhari Share your comments on this one.

@gigincg gigincg merged commit b3839b5 into coronasafe:master Mar 17, 2023
Copy link
Member

@vigneshhari vigneshhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes Required

care/facility/api/serializers/file_upload.py Show resolved Hide resolved
care/hcx/api/serializers/claim.py Show resolved Hide resolved
care/hcx/api/serializers/claim.py Show resolved Hide resolved
care/hcx/api/serializers/claim.py Show resolved Hide resolved
care/hcx/api/serializers/claim.py Show resolved Hide resolved
care/hcx/api/serializers/claim.py Show resolved Hide resolved
care/hcx/api/viewsets/claim.py Show resolved Hide resolved
care/hcx/api/viewsets/claim.py Show resolved Hide resolved
Ashesh3 pushed a commit to Ashesh3/care that referenced this pull request Mar 22, 2023
Co-authored-by: Mathew Alex <matthewzalex@gmail.com>
Co-authored-by: Gigin George <mail.gigin@gmail.com>
@khavinshankar khavinshankar mentioned this pull request Mar 24, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants