Add additional fields in shifting form #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #1265 +/- ##
==========================================
+ Coverage 56.28% 56.33% +0.04%
==========================================
Files 195 195
Lines 9565 9575 +10
Branches 1606 1606
==========================================
+ Hits 5384 5394 +10
Misses 4126 4126
Partials 55 55
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
vigneshhari
approved these changes
Apr 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for coronasafe/care_fe#5323
Related Issue: coronasafe/care_fe#5300
This pull request adds new fields to the Shifting Serializer and the Shifting Request model.
In the Shifting Serializer, the following changes the made:
patient_category: a ChoiceField with the following options: 'Comfort Care', 'Stable', 'Abnormal' and 'Critical'ambulance_driver_name: a CharField that allows blank and null valuesambulance_phone_number: a PhoneNumberIsPossibleField that allows blank and null valuesambulance_number: a CharField that allows blank and null valuesIn the Shifting Request model, the following fields are added:
ambulance_driver_name: a TextField that allows blank valuesambulance_phone_number: a CharField that allows blank values and is validated with a RegexValidatorambulance_number: a TextField that allows blank valuespatient_category: a CharField with the same options as the Shifting Serializer's patient_category field.@coronasafe/code-reviewers