Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds Camera Preset model #2062

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented Apr 8, 2024

Feature Request

Proposed Changes

  • Adds Camera Preset model and serializer
  • Removes version from compose files as it has become obsolete.

References: https://github.com/compose-spec/compose-spec/blob/master/spec.md#version-top-level-element

While starting compose:
image

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

Signed-off-by: Abhiuday <contact.abhiuday@gmail.com>
Signed-off-by: Abhiuday <contact.abhiuday@gmail.com>
@aeswibon aeswibon marked this pull request as ready for review April 18, 2024 14:49
@aeswibon aeswibon requested a review from a team as a code owner April 18, 2024 14:49
Signed-off-by: Abhiuday <contact.abhiuday@gmail.com>
Signed-off-by: Abhiuday <contact.abhiuday@gmail.com>
@aeswibon aeswibon marked this pull request as draft April 18, 2024 18:06
@aeswibon aeswibon marked this pull request as ready for review April 19, 2024 14:05
Signed-off-by: Abhiuday <contact.abhiuday@gmail.com>
@nihal467
Copy link
Member

nihal467 commented May 8, 2024

@aeswibon fix the bugs in the related frontend PR's

@vigneshhari only review the PR and dont merge it due to bugs in the related frontend PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants