Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prescriptions and MAR: Disallow users to perform edits on discharged encounters #2133

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion care/facility/api/serializers/prescription.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,13 @@

return super().validate(attrs)

def create(self, validated_data):
if validated_data["prescription"].consultation.discharge_date:
raise serializers.ValidationError(
{"consultation": "Not allowed for discharged consultations"}
)
return super().create(validated_data)

class Meta:
model = MedicineAdministration
exclude = ("deleted",)
Expand Down Expand Up @@ -149,4 +156,10 @@
attrs.pop("target_dosage", None)

return super().validate(attrs)
# TODO: Ensure that this medicine is not already prescribed to the same patient and is currently active.

def create(self, validated_data):
if validated_data["consultation"].discharge_date:
raise serializers.ValidationError(

Check warning on line 162 in care/facility/api/serializers/prescription.py

View check run for this annotation

Codecov / codecov/patch

care/facility/api/serializers/prescription.py#L162

Added line #L162 was not covered by tests
{"consultation": "Not allowed for discharged consultations"}
)
return super().create(validated_data)
11 changes: 10 additions & 1 deletion care/facility/api/viewsets/prescription.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from rest_framework.decorators import action
from rest_framework.permissions import IsAuthenticated
from rest_framework.response import Response
from rest_framework.serializers import ValidationError
from rest_framework.viewsets import GenericViewSet, ViewSet

from care.facility.api.serializers.prescription import (
Expand Down Expand Up @@ -78,6 +79,10 @@ def get_queryset(self):
@extend_schema(tags=["prescription_administration"])
@action(methods=["POST"], detail=True)
def archive(self, request, *args, **kwargs):
if self.get_consultation_obj().discharge_date:
rithviknishad marked this conversation as resolved.
Show resolved Hide resolved
raise ValidationError(
{"consultation": "Not allowed for discharged consultations"}
)
instance = self.get_object()
if instance.archived_on:
return Response(
Expand Down Expand Up @@ -137,12 +142,16 @@ def perform_create(self, serializer):
detail=True,
)
def discontinue(self, request, *args, **kwargs):
consultation_obj = self.get_consultation_obj()
if consultation_obj.discharge_date:
raise ValidationError(
{"consultation": "Not allowed for discharged consultations"}
)
prescription_obj = self.get_object()
prescription_obj.discontinued = True
prescription_obj.discontinued_reason = request.data.get(
"discontinued_reason", None
)
consultation_obj = self.get_consultation_obj()
NotificationGenerator(
event=Notification.Event.PATIENT_PRESCRIPTION_UPDATED,
caused_by=self.request.user,
Expand Down
189 changes: 189 additions & 0 deletions care/facility/tests/test_medicine_administrations_api.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,189 @@
from django.utils import timezone
from rest_framework import status
from rest_framework.test import APITestCase

from care.facility.models import (
MedibaseMedicine,
MedicineAdministration,
Prescription,
PrescriptionDosageType,
)
from care.utils.tests.test_utils import TestUtils


class MedicineAdministrationsApiTestCase(TestUtils, APITestCase):
@classmethod
def setUpTestData(cls) -> None:
cls.state = cls.create_state()
cls.district = cls.create_district(cls.state)
cls.local_body = cls.create_local_body(cls.district)
cls.super_user = cls.create_super_user("su", cls.district)
cls.facility = cls.create_facility(cls.super_user, cls.district, cls.local_body)
cls.user = cls.create_user("nurse1", cls.district, home_facility=cls.facility)
cls.patient = cls.create_patient(
cls.district, cls.facility, local_body=cls.local_body
)
cls.remote_facility = cls.create_facility(
cls.super_user, cls.district, cls.local_body
)
cls.remote_user = cls.create_user(
"remote-nurse", cls.district, home_facility=cls.remote_facility
)
cls.discharged_patient = cls.create_patient(
cls.district, cls.facility, local_body=cls.local_body
)
cls.discharged_consultation = cls.create_consultation(
cls.discharged_patient, cls.facility, discharge_date="2024-01-04T00:00:00Z"
)

def setUp(self) -> None:
super().setUp()
self.normal_prescription = self.create_prescription()
self.discharged_prescription = self.create_prescription(
consultation=self.discharged_consultation
)
self.discharged_administration = self.create_medicine_administration(
prescription=self.discharged_prescription
)

def create_prescription(self, **kwargs):
patient = kwargs.pop("patient", self.patient)
consultation = kwargs.pop(
"consultation", self.create_consultation(patient, self.facility)
)
data = {
"consultation": consultation,
"medicine": MedibaseMedicine.objects.first(),
"prescription_type": "REGULAR",
"base_dosage": "1 mg",
"frequency": "OD",
"dosage_type": kwargs.get(
"dosage_type", PrescriptionDosageType.REGULAR.value
),
}
return Prescription.objects.create(
**{**data, **kwargs, "prescribed_by": self.user}
)

def create_medicine_administration(self, prescription, **kwargs):
return MedicineAdministration.objects.create(
prescription=prescription, administered_by=self.user, **kwargs
)

def test_administer_for_discharged_consultations(self):
prescription = self.discharged_prescription
res = self.client.post(
f"/api/v1/consultation/{prescription.consultation.external_id}/prescriptions/{prescription.external_id}/administer/",
)
self.assertEqual(res.status_code, status.HTTP_400_BAD_REQUEST)

def test_archive_for_discharged_consultations(self):
res = self.client.post(
f"/api/v1/consultation/{self.discharged_prescription.consultation.external_id}/prescription_administration/{self.discharged_administration.external_id}/archive/"
)
self.assertEqual(res.status_code, status.HTTP_400_BAD_REQUEST)

def test_administer_non_home_facility(self):
self.client.force_authenticate(self.remote_user)
prescription = self.discharged_prescription
res = self.client.post(
f"/api/v1/consultation/{prescription.consultation.external_id}/prescriptions/{prescription.external_id}/administer/",
)
self.assertEqual(res.status_code, status.HTTP_404_NOT_FOUND)

def test_archive_non_home_facility(self):
self.client.force_authenticate(self.remote_user)
res = self.client.post(
f"/api/v1/consultation/{self.discharged_prescription.consultation.external_id}/prescription_administration/{self.discharged_administration.external_id}/archive/"
)
self.assertEqual(res.status_code, status.HTTP_404_NOT_FOUND)

def test_administer_and_archive(self):
# test administer
prescription = self.normal_prescription
res = self.client.post(
f"/api/v1/consultation/{prescription.consultation.external_id}/prescriptions/{prescription.external_id}/administer/",
{"notes": "Test Notes"},
)
self.assertEqual(res.status_code, status.HTTP_201_CREATED)

administration_id = res.data["id"]

# test archive
archive_path = f"/api/v1/consultation/{prescription.consultation.external_id}/prescription_administration/{administration_id}/archive/"
res = self.client.post(archive_path, {})
self.assertEqual(res.status_code, status.HTTP_200_OK)

# test archive again
res = self.client.post(archive_path, {})
self.assertEqual(res.status_code, status.HTTP_400_BAD_REQUEST)

# test list administrations
res = self.client.get(
f"/api/v1/consultation/{prescription.consultation.external_id}/prescription_administration/"
)
self.assertEqual(res.status_code, status.HTTP_200_OK)
self.assertTrue(
any([administration_id == x["id"] for x in res.data["results"]])
)

# test archived list administrations
res = self.client.get(
f"/api/v1/consultation/{prescription.consultation.external_id}/prescription_administration/?archived=true"
)
self.assertEqual(res.status_code, status.HTTP_200_OK)
self.assertTrue(
any([administration_id == x["id"] for x in res.data["results"]])
)

# test archived list administrations
res = self.client.get(
f"/api/v1/consultation/{prescription.consultation.external_id}/prescription_administration/?archived=false"
)
self.assertEqual(res.status_code, status.HTTP_200_OK)
self.assertFalse(
any([administration_id == x["id"] for x in res.data["results"]])
)

def test_administer_in_future(self):
prescription = self.normal_prescription
res = self.client.post(
f"/api/v1/consultation/{prescription.consultation.external_id}/prescriptions/{prescription.external_id}/administer/",
{"notes": "Test Notes", "administered_date": "2300-09-01T16:34"},
)
self.assertEqual(res.status_code, status.HTTP_400_BAD_REQUEST)

def test_administer_in_past(self):
prescription = self.normal_prescription
res = self.client.post(
f"/api/v1/consultation/{prescription.consultation.external_id}/prescriptions/{prescription.external_id}/administer/",
{"notes": "Test Notes", "administered_date": "2019-09-01T16:34"},
)
self.assertEqual(res.status_code, status.HTTP_400_BAD_REQUEST)

def test_administer_discontinued(self):
prescription = self.create_prescription(
discontinued=True, discontinued_date=timezone.now()
)
res = self.client.post(
f"/api/v1/consultation/{prescription.consultation.external_id}/prescriptions/{prescription.external_id}/administer/",
{"notes": "Test Notes"},
)
self.assertEqual(res.status_code, status.HTTP_400_BAD_REQUEST)

def test_administer_titrated_dosage(self):
prescription = self.create_prescription(
dosage_type=PrescriptionDosageType.TITRATED.value, target_dosage="10 mg"
)
res = self.client.post(
f"/api/v1/consultation/{prescription.consultation.external_id}/prescriptions/{prescription.external_id}/administer/",
{"notes": "Test Notes"},
)
self.assertEqual(res.status_code, status.HTTP_400_BAD_REQUEST)

res = self.client.post(
f"/api/v1/consultation/{prescription.consultation.external_id}/prescriptions/{prescription.external_id}/administer/",
{"notes": "Test Notes", "dosage": "1 mg"},
)

self.assertEqual(res.status_code, status.HTTP_201_CREATED)
Loading