Refactor get_users API to show proper swagger documentation #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
vigneshhari
requested changes
May 26, 2022
|
|
||
| def get_queryset(self): | ||
| try: | ||
| facility = Facility.objects.get(external_id=self.kwargs.get("facility_external_id")) |
There was a problem hiding this comment.
@gigincg does this endpoint need authorisation?
|
you can also add swagger docs by using the fake schema generator that YASG provides |
vigneshhari
approved these changes
Jul 3, 2022
|
|
||
| def get_queryset(self): | ||
| try: | ||
| facility = Facility.objects.get(external_id=self.kwargs.get("facility_external_id")) |
vigneshhari
approved these changes
Jul 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the
get_usersAPI (under facility) to make the user role (user_type) filter visible in the swagger UI.Fixes: #711