Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent type of visited countries attribute #789

Merged
merged 3 commits into from
Jan 22, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented May 26, 2022

Related issue: care_fe/issues/2440
Frontend change: care_fe/pull/2536

This change fixes countries_travelled being referenced as a CharField at other places, which causes issues when displaying the data at the frontend.

Copy link
Member

@vigneshhari vigneshhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to study the effect of existing null values in FE and BE, otherwise good to go.

@Ashesh3
Copy link
Member Author

Ashesh3 commented Sep 28, 2022

@vigneshhari Any updates on this being merged?

@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Base: 56.08% // Head: 56.08% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (7d8da1d) compared to base (8cbb1c6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #789   +/-   ##
=======================================
  Coverage   56.08%   56.08%           
=======================================
  Files         175      175           
  Lines        8616     8617    +1     
  Branches     1460     1475   +15     
=======================================
+ Hits         4832     4833    +1     
  Misses       3732     3732           
  Partials       52       52           
Impacted Files Coverage Δ
care/facility/api/serializers/patient_icmr.py 100.00% <100.00%> (ø)
care/facility/api/serializers/patient_sample.py 60.00% <100.00%> (ø)
care/users/api/viewsets/change_password.py 61.53% <0.00%> (+1.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ashesh3
Copy link
Member Author

Ashesh3 commented Jan 13, 2023

@vigneshhari Any updates on this?

@vigneshhari vigneshhari merged commit 981f627 into coronasafe:master Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants