Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unused network in docker-compose and removes unnecessary port bindings #887

Merged
merged 2 commits into from
Jun 24, 2022
Merged

Fix unused network in docker-compose and removes unnecessary port bindings #887

merged 2 commits into from
Jun 24, 2022

Conversation

rithviknishad
Copy link
Member

Closes #886

  • Removes network creation from Makefile and let compose itself handle it.
  • Removes unnecessary port bindings.

Now only care service's port is bound to the host.

image

@rithviknishad rithviknishad requested a review from a team as a code owner June 24, 2022 06:48
@vigneshhari vigneshhari merged commit da4ed80 into coronasafe:master Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshhari vigneshhari vigneshhari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running make up creates unused network care and care_default
2 participants
@rithviknishad @vigneshhari