Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dummy data seeding #929

Closed
wants to merge 6 commits into from
Closed

Conversation

Marmik2003
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2022

Codecov Report

Merging #929 (e65b68f) into master (885d001) will decrease coverage by 1.38%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #929      +/-   ##
==========================================
- Coverage   54.14%   52.75%   -1.39%     
==========================================
  Files         181      182       +1     
  Lines        8922     8918       -4     
==========================================
- Hits         4831     4705     -126     
- Misses       4091     4213     +122     
Impacted Files Coverage Δ
care/users/fixtures.py 0.00% <0.00%> (ø)
care/users/management/commands/seed_data.py 0.00% <0.00%> (ø)
...e/utils/serializer/phonenumber_ispossible_field.py 50.00% <0.00%> (-43.75%) ⬇️
config/serializers.py 36.84% <0.00%> (-31.58%) ⬇️
care/audit_log/middleware.py 47.36% <0.00%> (-22.81%) ⬇️
care/users/models.py 73.94% <0.00%> (-16.20%) ⬇️
...are/facility/models/mixins/permissions/facility.py 34.78% <0.00%> (-15.22%) ⬇️
care/users/api/viewsets/users.py 43.50% <0.00%> (-12.34%) ⬇️
care/facility/api/viewsets/facility.py 51.11% <0.00%> (-10.00%) ⬇️
care/users/api/serializers/user.py 56.77% <0.00%> (-9.33%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 885d001...e65b68f. Read the comment docs.

@Marmik2003 Marmik2003 marked this pull request as ready for review July 19, 2022 14:50
@Marmik2003 Marmik2003 requested a review from a team as a code owner July 19, 2022 14:50
@Marmik2003
Copy link
Contributor Author

fixes #920

@vigneshhari
Copy link
Member

The dummy data has a lot of real names and phone numbers, let's make it anonymized.
This method does not account for migrations that might happen later, we need a more dynamic seeder.

@vigneshhari
Copy link
Member

Also delete the commit that adds the file for the sake of maintaining anonymity

@Marmik2003 Marmik2003 marked this pull request as draft July 27, 2022 07:58
@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
2.4% 2.4% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants