Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update permissions for write access #946

Merged
merged 2 commits into from
Jul 29, 2022
Merged

update permissions for write access #946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f757cf9
update permissions for write access
iamsdas Jul 24, 2022
3265182
update write access permission for staff
iamsdas Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions care/facility/models/mixins/permissions/facility.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,12 @@ def has_object_write_permission(self, request):
or request.user.user_type == User.TYPE_VALUE_MAP["StaffReadOnly"]
):
return False
if request.user.user_type < User.TYPE_VALUE_MAP["Staff"]: # todo Temporary
return False
return self.has_object_read_permission(request)
if (
request.user.user_type >= User.TYPE_VALUE_MAP["DistrictAdmin"]
or request.user.user_type == User.TYPE_VALUE_MAP["Staff"]
):
return self.has_object_read_permission(request)
vigneshhari marked this conversation as resolved.
Show resolved Hide resolved
return request.user.home_facility == self

def has_object_update_permission(self, request):
return super().has_object_update_permission(request) or self.has_object_write_permission(request)
Expand Down
13 changes: 9 additions & 4 deletions care/facility/models/mixins/permissions/patient.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,8 @@ def has_write_permission(request):
return False
return (
request.user.is_superuser
or request.user.verified
and request.user.user_type >= User.TYPE_VALUE_MAP["Staff"]
or request.user.user_type >= User.TYPE_VALUE_MAP["DistrictAdmin"]
or request.user.user_type == User.TYPE_VALUE_MAP["Doctor"]
)

def has_object_read_permission(self, request):
Expand All @@ -148,7 +148,12 @@ def has_object_update_permission(self, request):
if (
request.user.user_type == User.TYPE_VALUE_MAP["DistrictReadOnlyAdmin"]
or request.user.user_type == User.TYPE_VALUE_MAP["StateReadOnlyAdmin"]
or request.user.user_type == User.TYPE_VALUE_MAP["StaffReadOnly"]
):
return False
return self.has_object_read_permission(request)
return (
self.has_object_read_permission(request)
and (
request.user.user_type == User.TYPE_VALUE_MAP["Doctor"]
or request.user.user_type >= User.TYPE_VALUE_MAP["DistrictAdmin"]
)
)