Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update facility write access for users #955

Merged
merged 1 commit into from
Jul 30, 2022

Conversation

iamsdas
Copy link
Contributor

@iamsdas iamsdas commented Jul 29, 2022

Related to this issue/comment.

@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #955 (68845b8) into master (df1b787) will decrease coverage by 1.42%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #955      +/-   ##
==========================================
- Coverage   54.14%   52.72%   -1.43%     
==========================================
  Files         181      181              
  Lines        8922     8924       +2     
==========================================
- Hits         4831     4705     -126     
- Misses       4091     4219     +128     
Impacted Files Coverage Δ
...are/facility/models/mixins/permissions/facility.py 34.78% <0.00%> (-15.22%) ⬇️
...e/utils/serializer/phonenumber_ispossible_field.py 50.00% <0.00%> (-43.75%) ⬇️
config/serializers.py 36.84% <0.00%> (-31.58%) ⬇️
care/audit_log/middleware.py 47.36% <0.00%> (-22.81%) ⬇️
care/users/models.py 73.94% <0.00%> (-16.20%) ⬇️
care/users/api/viewsets/users.py 43.50% <0.00%> (-12.34%) ⬇️
care/facility/api/viewsets/facility.py 51.11% <0.00%> (-10.00%) ⬇️
care/users/api/serializers/user.py 56.77% <0.00%> (-9.33%) ⬇️
care/facility/models/patient.py 88.09% <0.00%> (-6.75%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df1b787...68845b8. Read the comment docs.

@iamsdas iamsdas requested a review from gigincg July 30, 2022 07:19
@iamsdas iamsdas marked this pull request as ready for review July 30, 2022 14:23
@iamsdas iamsdas requested a review from a team as a code owner July 30, 2022 14:23
@vigneshhari vigneshhari merged commit c2cdced into coronasafe:master Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants