Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSV export for patients #972

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Aug 9, 2022

The commit 9277da5#diff-5f86d36c9415c5c40e8820c1e4f86aa28dd713d6a74a1adc1f387598b8b542b9L66 removed admitted_to from Patient Consultation.

However, the CSV export still references it, this causes patient exports to fail since this attribute no longer exists. This PR removes that attribute from CSV Columns. It also removes the admitted attribute, which is marked deprecated. (patient_consultation.py#L65)

@Ashesh3 Ashesh3 requested a review from a team as a code owner August 9, 2022 14:18
@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.2% 1.2% Duplication

@vigneshhari
Copy link
Member

This data can now be fetched from the current bed object, but that can be a different PR, just keep that in mind.

@vigneshhari vigneshhari merged commit 7810e26 into coronasafe:master Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants