Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more fields to Consultation Form #979

Closed
wants to merge 44 commits into from

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented Aug 15, 2022

Updates

@aeswibon aeswibon marked this pull request as ready for review August 31, 2022 10:04
@aeswibon aeswibon requested a review from a team as a code owner August 31, 2022 10:04
@gigincg
Copy link
Member

gigincg commented Sep 9, 2022

Waiting for FE before merging

@gigincg
Copy link
Member

gigincg commented Sep 9, 2022

@cp-Coder to Add Screenshot of Swagger Docs for the new Consultation API

@aeswibon
Copy link
Member Author

image

care/facility/api/serializers/patient_health_details.py Outdated Show resolved Hide resolved
care/facility/api/serializers/patient_health_details.py Outdated Show resolved Hide resolved
care/facility/api/serializers/patient_health_details.py Outdated Show resolved Hide resolved
care/facility/api/serializers/patient_health_details.py Outdated Show resolved Hide resolved
care/facility/api/serializers/patient_consultation.py Outdated Show resolved Hide resolved
care/facility/api/serializers/patient_consultation.py Outdated Show resolved Hide resolved
care/facility/api/serializers/patient_consultation.py Outdated Show resolved Hide resolved
care/facility/api/serializers/patient_consultation.py Outdated Show resolved Hide resolved
care/facility/api/serializers/patient_consultation.py Outdated Show resolved Hide resolved
care/facility/migrations/0310_auto_20220813_1123.py Outdated Show resolved Hide resolved
@vigneshhari
Copy link
Member

Let's not delete any fields immediately; let's keep a leeway of 1 month before deleting any data. remove any migration that deletes the columns.

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2022

Codecov Report

Base: 56.08% // Head: 56.13% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (c164c4e) compared to base (e7052a9).
Patch coverage: 51.97% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #979      +/-   ##
==========================================
+ Coverage   56.08%   56.13%   +0.05%     
==========================================
  Files         175      178       +3     
  Lines        8617     8689      +72     
  Branches     1460     1478      +18     
==========================================
+ Hits         4833     4878      +45     
- Misses       3732     3759      +27     
  Partials       52       52              
Impacted Files Coverage Δ
care/utils/notification_handler.py 16.80% <4.16%> (ø)
...e/facility/api/serializers/patient_consultation.py 32.50% <30.76%> (-1.60%) ⬇️
care/facility/api/viewsets/patient_otp.py 48.57% <33.33%> (-1.43%) ⬇️
...facility/api/serializers/patient_health_details.py 58.06% <58.06%> (ø)
care/facility/api/viewsets/patient.py 49.13% <61.90%> (+0.71%) ⬆️
care/facility/api/serializers/patient.py 56.93% <100.00%> (+0.91%) ⬆️
care/facility/models/json_schema/consultation.py 100.00% <100.00%> (ø)
care/facility/models/notification.py 100.00% <100.00%> (ø)
care/facility/models/patient.py 92.99% <100.00%> (+0.13%) ⬆️
care/facility/models/patient_base.py 100.00% <100.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

- Added facility & patient as ForeignKey field
- Added has_allergy as BooleanField
- Added family_details & allergies as TextField
- Added blood_group as CharField
- Added has_allergy as BooleanField
- Migrated blood_group & allergies fields from PatientRegistration Model
- Added import statement of PatientHealthDetails model
- Removed blood_group field from PatientListSerializer
- Removed allergies from exclude option of PatientListSerializer
- Added serializer for patient health details
* Added function to migrate previous data to new Vaccine model
* Added serializer field for vaccination in health details serializer
* Reformatted the code
* Added migrations for adding new notification events
* Added new fields in notification generator for health details
* Added notification generator in consultation serializers for health
  details
* Changed config file for flake8 to .flake8
* Removed all migrations for removing fields
* Merged all the migrations for health details model into one migration
* Refactored health details serializer
* Reformatted the code
* Added deleted fields with `#deprecated` text
* Reformatted the code
* Refactored the migrations
* Updated migrations' dependencies
* Added function to link health details with patient consultation
* Reverted back to medical history used
* Removed new MedicalHistory and Disease model
* Reformatted the code
* Switched to serializer to create/update health details record
* Added create/update method in health details serializer
* Added auth while creating health details record
* Switched to validated_data for health details data
* Reformatted the code
* Added vaccination in health details model as jsonfield
* Added schema for vaccintion field
* Removed vaccine model and its references
* Added vaccine, medical history nad disease model
* Added the migrations with function to migrate the data
* Added required serializers
* Reformatted the code
@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
4.4% 4.4% Duplication

@aeswibon
Copy link
Member Author

Will open a new PR squashing the commits

@aeswibon aeswibon closed this Oct 22, 2022
@aeswibon aeswibon deleted the issue#859 branch October 22, 2022 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants