Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed search issue and pagination issue #34

Merged
merged 6 commits into from
Oct 11, 2022
Merged

Fixed search issue and pagination issue #34

merged 6 commits into from
Oct 11, 2022

Conversation

khavinshankar
Copy link
Member

@khavinshankar khavinshankar commented Oct 10, 2022

Fixes #27
Fixes #28
Fixes #29

@vercel
Copy link

vercel bot commented Oct 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-dashboard ✅ Ready (Inspect) Visit Preview Oct 11, 2022 at 6:45AM (UTC)

@khavinshankar
Copy link
Member Author

  • Added tooltip for patient_discharge in capacity cards

Fixes #29

Copy link
Contributor

@developedBySJ developedBySJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a bug when you don't have any data and you click on the last page button
image

can you add an empty state (something like No facility found)?

src/components/tooltip.tsx Outdated Show resolved Hide resolved
src/pages/district/Capacity.tsx Outdated Show resolved Hide resolved
src/utils/hooks/usePaginateData.ts Outdated Show resolved Hide resolved
src/utils/hooks/usePaginateData.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tooltips to ambiguous data Pagination malfunction Search results are very fuzzy
2 participants