Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change scrollbar css according to theme #39

Merged
merged 2 commits into from
Oct 16, 2022
Merged

change scrollbar css according to theme #39

merged 2 commits into from
Oct 16, 2022

Conversation

Ritesh-Aggarwal
Copy link
Contributor

closes #38

image

image

@vercel
Copy link

vercel bot commented Oct 12, 2022

@Ritesh-Aggarwal is attempting to deploy a commit to the swapnil-egov Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 12, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-dashboard ✅ Ready (Inspect) Visit Preview Oct 14, 2022 at 0:09AM (UTC)

rithviknishad
rithviknishad approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🚀
Could you also add support for the custom scrollbar theme for firefox?

@Ritesh-Aggarwal
Copy link
Contributor Author

Looking good 🚀 Could you also add support for the custom scrollbar theme for firefox?

Thanks for pointing that out , will fix it for firefox too

@Ritesh-Aggarwal
Copy link
Contributor Author

Doesn't firefox default scrollbar look better?

image

image

@rithviknishad
Copy link
Member

Yup. I just thought to have a consistent experience regardless of the browser.

@developedBySJ
Copy link
Contributor

@rithviknishad Let's keep it default for firefox.

@developedBySJ developedBySJ merged commit 2185be8 into coronasafe:master Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@developedBySJ developedBySJ developedBySJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scrollbar dark/light mode
3 participants
@Ritesh-Aggarwal @rithviknishad @developedBySJ