Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateRangePickerV2 should not allow selecting end date that's before start date. #3983

Closed
rithviknishad opened this issue Nov 6, 2022 · 5 comments · Fixed by #4329
Closed
Assignees

Comments

@rithviknishad
Copy link
Member

Describe the bug
Currently in the DateRangePickerV2 component, it allows picking an end date that's before the start date. This should not be allowed.

To Reproduce
Steps to reproduce the behavior:

  1. Go to advanced patient filter.
  2. Set any of the date filters to reproduce the above issue.

Expected behavior
The dates in the end date should not be selectable/clickable that's before the start date.

Screenshots

2022-11-06.20-12-58.mp4

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@aeswibon aeswibon self-assigned this Nov 6, 2022
@github-actions
Copy link

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity.

@github-actions github-actions bot added the stale label Nov 21, 2022
@aeswibon aeswibon removed the stale label Nov 21, 2022
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity.

@github-actions github-actions bot added the stale label Dec 6, 2022
@khavinshankar
Copy link
Member

@cp-Coder what's the status of this issue

cc: @nihal467

@github-actions github-actions bot removed the stale label Dec 7, 2022
@aeswibon
Copy link
Member

aeswibon commented Dec 9, 2022

The issue has already been fixed

@aeswibon aeswibon closed this as not planned Won't fix, can't repro, duplicate, stale Dec 9, 2022
@rithviknishad
Copy link
Member Author

Issue is still present in the patient filters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants