Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unicons leaked into care #4237

Closed
rithviknishad opened this issue Dec 6, 2022 · 0 comments · Fixed by #4238
Closed

Unicons leaked into care #4237

rithviknishad opened this issue Dec 6, 2022 · 0 comments · Fixed by #4238
Assignees
@rithviknishad
Labels
Done P1 breaking issue or vital feature urgent

Comments

@rithviknishad
Copy link
Member

rithviknishad commented Dec 6, 2022 •
edited
Loading

Describe the bug
Some PRs which were getting merged parallel to CareIcons PR #4071 introduced new usage of unicons, which was gone undetected.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Patient home

Expected behavior
Migrate new usages of unicons to CareIcons

Screenshots

image

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rithviknishad rithviknishad

Labels
Done P1 breaking issue or vital feature urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate leaked unicons to CareIcons coronasafe/care_fe
2 participants
@Ashesh3 @rithviknishad