Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate leaked unicons to CareIcons #4238

Merged
merged 7 commits into from
Dec 7, 2022
Merged

Conversation

rithviknishad
Copy link
Member

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@vercel
Copy link

vercel bot commented Dec 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 6, 2022 at 2:15PM (UTC)

@netlify
Copy link

netlify bot commented Dec 6, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 037fe9b
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/638f4e547a4a1900088a7d99
😎 Deploy Preview https://deploy-preview-4238--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rithviknishad rithviknishad added urgent P1 breaking issue or vital feature labels Dec 6, 2022
@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Dec 6, 2022
@rithviknishad rithviknishad marked this pull request as ready for review December 6, 2022 14:10
@rithviknishad rithviknishad requested a review from a team December 6, 2022 14:10
@rithviknishad rithviknishad requested a review from a team as a code owner December 6, 2022 14:10
@rithviknishad rithviknishad added needs testing and removed work-in-progress cypress failed pull request with cypress test failure labels Dec 6, 2022
@nihal467
Copy link
Member

nihal467 commented Dec 6, 2022

@rithviknishad
image

the icon of assign to volunteer, in responsive view, is not uniform

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Dec 6, 2022
@rithviknishad
Copy link
Member Author

@nihal467 fixed it

@sonarcloud
Copy link

sonarcloud bot commented Dec 6, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.3% 3.3% Duplication

@nihal467
Copy link
Member

nihal467 commented Dec 6, 2022

LGTM

@khavinshankar khavinshankar merged commit b25b93b into develop Dec 7, 2022
aeswibon pushed a commit to aeswibon/care_fe that referenced this pull request Dec 8, 2022
* migrate icons in Breadcrumbs

* migrate icons in ONVIFCamera

* migrate icons in ConsultationCard

* migrate icons in new textformfield: show password

* migrate icons in sample test card

* migrate icons in patient home

* fix assign volunteer icon size
@rithviknishad rithviknishad deleted the careui/icons-fix#4237 branch July 26, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure P1 breaking issue or vital feature tested urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unicons leaked into care
4 participants