Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight English as default language if no language preference present. #5057

Closed
rithviknishad opened this issue Mar 8, 2023 · 0 comments · Fixed by #5059
Closed

Highlight English as default language if no language preference present. #5057

rithviknishad opened this issue Mar 8, 2023 · 0 comments · Fixed by #5059
Assignees
@rithviknishad

Comments

@rithviknishad
Copy link
Member

If the user has never selected a language in care, it'll be blank and English is not highlighted. Because only when a user selects a language, the preference is stored in the local storage.

This issue is easily noticeable in all deploy previews.

In my fresh staging (see image) I've never selected a language, so it's not highlighted.

image

Originally posted by @rithviknishad in #5047 (review)
@rithviknishad rithviknishad self-assigned this Mar 8, 2023
rithviknishad added a commit to rithviknishad/care_fe that referenced this issue Mar 8, 2023
@rithviknishad
fixes ohcnetwork#5057
3e847cb
@rithviknishad rithviknishad mentioned this issue Mar 8, 2023
Merged
6 tasks
khavinshankar pushed a commit that referenced this issue Mar 13, 2023
@rithviknishad
Highlight English as default language if no language preference prese…
302e679 
…nt. (#5059)

* fixes #5057

* optimize logic

* fix logic to check if `en-US` instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rithviknishad rithviknishad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Highlight English as default language if no language preference present. rithviknishad/care_fe
1 participant
@rithviknishad