Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warranty expiry in past is not allowing asset detail page to update #1500

Closed
nihal467 opened this issue Aug 2, 2023 · 1 comment · Fixed by #1502
Closed

Warranty expiry in past is not allowing asset detail page to update #1500

nihal467 opened this issue Aug 2, 2023 · 1 comment · Fixed by #1502
Assignees
@rithviknishad
Labels
Backend

Comments

@nihal467
Copy link
Member

nihal467 commented Aug 2, 2023

Describe the bug

When updating the asset details, if the warranty expiry is in the past, it becomes difficult to update other fields in the existing form.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://care.coronasafe.in/facility/1193b6cb-0b31-47b8-8c5f-a5c819114359/assets/ff99d042-4e40-4908-81a7-e1e1aa3a1e3b/update
  2. Update the form
  3. See error

Expected behavior

To be discussed on EOD Call

Screenshots

image
@rithviknishad
Copy link
Member

We should skip validating the warranty_amc_end_of_validity field if the field is not changed.

@rithviknishad rithviknishad transferred this issue from ohcnetwork/care_fe Aug 2, 2023
@rithviknishad rithviknishad self-assigned this Aug 2, 2023
@rithviknishad rithviknishad mentioned this issue Aug 2, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rithviknishad rithviknishad

Labels
Backend
Projects
Care
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip validation if asset warranty date is not changed ohcnetwork/care
2 participants
@rithviknishad @nihal467