Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show loading state for fetching asset locations in Asset Import #6489

Closed
Ashesh3 opened this issue Oct 25, 2023 · 4 comments
Closed

Show loading state for fetching asset locations in Asset Import #6489

Ashesh3 opened this issue Oct 25, 2023 · 4 comments
Assignees

Comments

@Ashesh3
Copy link
Member

Ashesh3 commented Oct 25, 2023

In the Asset Import modal, the loader for when the locations are still being fetched does not work anymore..
Functionality for setLocationsLoading was removed. We need to add back the loading state.

Refer to this change for more info:

https://github.com/coronasafe/care_fe/pull/6374/files#diff-abdb9a86f18dd154c547c5b8884c695e30d12d0e9b8775bbff93cdcfcd7b6132L48

Originally posted by @Ashesh3 in #6374 (comment)

@shyamprakash123
Copy link
Contributor

I want to work on this, assign me

@Ashesh3
Copy link
Member Author

Ashesh3 commented Oct 25, 2023

I want to work on this, assign me

You are assigned.

@shyamprakash123
Copy link
Contributor

@Ashesh3 setLocationsLoading is removed and in place of that loading variable of useQuery is used to handle the loading state. If I'm wrong correct me. Can you provide a screenshot of the problem for a better understanding?

@Ashesh3
Copy link
Member Author

Ashesh3 commented Oct 25, 2023

@Ashesh3 setLocationsLoading is removed and in place of that loading variable of useQuery is used to handle the loading state. If I'm wrong correct me. Can you provide a screenshot of the problem for a better understanding?

I noticed that this issue was just fixed with rithviknishad in this PR: #6494 . Closing this issue as resolved.

@Ashesh3 Ashesh3 closed this as completed Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants