Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint CI: Show errors only and fix existing lint errors #6494

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Oct 25, 2023

WHAT

🤖 Generated by Copilot at 2733a66

This pull request improves the code quality and performance of some components in the src/Components/Assets folder, fixes some formatting issues in the linter workflow, and refines the prop type of the FiltersSlideover component.

Proposed Changes

  • Annotate lint errors only (skip warnings, as we have 2K+ warnings and would show up on all non-related PRs)
  • Fix existing lint errors.

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 2733a66

  • Fix indentation and add --quiet flag to linter workflow (link)
  • Change children prop type from any to ReactNode | ReactNode[] in FiltersSlideover component (link)
  • Remove unused states and simplify useQuery hook in AssetImportModal component (link, link, link)
  • Remove empty line and trailing whitespace in ONVIFCamera component (link, link)

@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview Oct 25, 2023 1:50pm

@netlify
Copy link

netlify bot commented Oct 25, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 2733a66
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65391d2cc99acc00088671ab
😎 Deploy Preview https://deploy-preview-6494--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rithviknishad rithviknishad marked this pull request as ready for review October 25, 2023 13:50
@rithviknishad rithviknishad requested a review from a team October 25, 2023 13:50
@rithviknishad rithviknishad requested a review from a team as a code owner October 25, 2023 13:50
@cypress
Copy link

cypress bot commented Oct 25, 2023

Passing run #1468 ↗︎

0 85 0 0 Flakiness 0

Details:

Lint CI: Show errors only and fix existing lint errors
Project: CARE Commit: 2733a662f2
Status: Passed Duration: 03:23 💡
Started: Oct 25, 2023 1:54 PM Ended: Oct 25, 2023 1:58 PM

Review all test suite changes for PR #6494 ↗︎

@khavinshankar khavinshankar merged commit 0ea1a1f into develop Oct 25, 2023
61 checks passed
@github-actions
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@khavinshankar khavinshankar deleted the lint-ci/errors-only-and-fix-existing-lints branch October 25, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants