Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registering assets with state admin read-only account #7081

Open
Sunilsubba opened this issue Jan 23, 2024 · 3 comments · May be fixed by coronasafe/care#2252
Open

Registering assets with state admin read-only account #7081

Sunilsubba opened this issue Jan 23, 2024 · 3 comments · May be fixed by coronasafe/care#2252
Assignees
@rithviknishad
Labels
Backend bug Something isn't working Frontend good first issue Good for newcomers work-in-progress

Comments

@Sunilsubba
Copy link

----Describe the bug-----

State Admin Read-only users are restricted from registering an asset. However, if we write the complete URL (.../assets/new), we can register an asset successfully.

----Steps to Reproduce----
1- Log in using provided credentials
2- Click https://care.coronasafe.in/facility/497fd4fc-c5c1-4ed3-9b57-64cc881087fe/assets/new
3- Fill the asset details
4- Click on "Create Asset"

----Login Credentials----
Username: state_read123
Password: Lilo@123

----Screenshots----
IMG_20240123_144617.jpg

IMG_20240123_144554.jpg
@rithviknishad
Copy link
Member

rithviknishad commented Jan 23, 2024 •
edited
Loading

Anyone working on this can use the newly added AuthorizeUserRoute to protect this route from certain user types (along with permission checks in backend)

@rithviknishad rithviknishad added the good first issue Good for newcomers label Jan 23, 2024
@kshitijv256
Copy link
Contributor

I can work on this

@kshitijv256 kshitijv256 mentioned this issue Jan 27, 2024
Closed
@kshitijv256 kshitijv256 mentioned this issue Feb 1, 2024
Closed
@Sunilsubba
Copy link
Author

Sunilsubba commented Jun 6, 2024 •
edited
Loading

Bug is still valid

@rithviknishad rithviknishad added the bug Something isn't working label Jun 6, 2024
@rithviknishad rithviknishad linked a pull request Jun 6, 2024 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rithviknishad rithviknishad

Labels
Backend bug Something isn't working Frontend good first issue Good for newcomers work-in-progress
Projects
Care
Status: Up Next
Milestone
No milestone
3 participants
@rithviknishad @kshitijv256 @Sunilsubba