Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added authorization on route for asset creation #7111

Closed
wants to merge 4 commits into from
Closed

Added authorization on route for asset creation #7111

wants to merge 4 commits into from

Conversation

kshitijv256
Copy link
Contributor

@kshitijv256 kshitijv256 commented Jan 27, 2024 •
edited
Loading

Proposed Changes

Related backend PR

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@kshitijv256 kshitijv256 requested a review from a team as a code owner January 27, 2024 11:00
@netlify Netlify
Copy link

netlify bot commented Jan 27, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 2d759fb
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65d8671dcbca960008d18cbe
😎 Deploy Preview https://deploy-preview-7111--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vercel Vercel
Copy link

vercel bot commented Jan 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 9:37am

rithviknishad
rithviknishad requested changes Jan 27, 2024
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kshitijv256 Update permissions in backend too to disallow this operation for read only users

src/Utils/AuthorizeFor.tsx Outdated Show resolved Hide resolved
@rithviknishad rithviknishad mentioned this pull request Feb 23, 2024
Closed
rithviknishad
rithviknishad requested changes Feb 23, 2024
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by mistake

@rithviknishad
Copy link
Member

@kshitijv256 still not followed up on the backend PR
coronasafe/care#1868 (review)

@kshitijv256
Copy link
Contributor Author

@rithviknishad I have made the requested changes in backed PR as well, can I take on other issues or wait for that to be closed first ?

@rithviknishad
Copy link
Member

rithviknishad commented Feb 23, 2024 •
edited
Loading

Yes @kshitijv256 you can take other issues 🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 2, 2024

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 2, 2024
@github-actions GitHub Actions
Copy link

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr.

@github-actions github-actions bot closed this Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

Assignees
No one assigned
Labels
changes required stale waiting for backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Registering assets with state admin read-only account
2 participants
@kshitijv256 @rithviknishad