Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed QR code #2343

Closed
wants to merge 3 commits into from
Closed

fixed QR code #2343

wants to merge 3 commits into from

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented May 13, 2022

Updates

  • Fixes link the generated QR and assigned QR on assets page #2241
  • Fixed asset Url (QR scanner will redirect to asset page on scanning QR code with asset id or qr_code_id )
  • Tested on QR code with value ffe4159f-ce44-4881-8fba-6a7d560280b5(asset UUID) or https://<hostname>?assetId="1234577777"(url with qr_code_id)

@aeswibon aeswibon requested a review from a team May 13, 2022 17:25
@gigincg
Copy link
Member

gigincg commented May 15, 2022

@cp-Coder Asset Transfers where being managed by the external-id QR Codes. You need to preserve that function as well in this

@nihal467 nihal467 added question Further information is requested and removed needs testing labels May 17, 2022
@nihal467
Copy link
Member

@gigincg @cp-Coder is it good for testing ?

@nihal467
Copy link
Member

@cp-Coder @gigincg the deployment preview is failed

@aeswibon aeswibon requested a review from a team as a code owner June 2, 2022 11:59
@nihal467 nihal467 added Deploy-Failed Deplyment is not showing preview and removed needs testing labels Jun 2, 2022
@nihal467
Copy link
Member

nihal467 commented Jun 2, 2022

@cp-Coder @gigincg check the deployment failed issue

@nihal467
Copy link
Member

@gigincg

@vercel
Copy link

vercel bot commented Jun 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-fe ✅ Ready (Inspect) Visit Preview Jun 13, 2022 at 3:54PM (UTC)

@aeswibon
Copy link
Member Author

@gigincg I have made the necessary changes

@aeswibon
Copy link
Member Author

Will open a new PR with existing as well as new changes

@aeswibon aeswibon closed this Jun 15, 2022
@aeswibon aeswibon deleted the issue#2241 branch June 18, 2022 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

link the generated QR and assigned QR on assets page
4 participants