Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Keyboard Shortcuts for Camera Live Feed #2381

Merged
merged 22 commits into from
May 25, 2022
Merged

Feature: Keyboard Shortcuts for Camera Live Feed #2381

merged 22 commits into from
May 25, 2022

Conversation

rithviknishad
Copy link
Member

Fixes #2374

  • Adds support for shortcut keys in camera feed controls. See Shortcuts
  • Adds tooltip that shows label and keyboard shortcut to trigger
    image

@rithviknishad rithviknishad requested a review from a team May 17, 2022 02:18
developedBySJ
developedBySJ suggested changes May 17, 2022
View reviewed changes
Copy link
Contributor

@developedBySJ developedBySJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add keyboard shortcuts to patient feed as well

package.json Outdated Show resolved Hide resolved
@rithviknishad rithviknishad removed the request for review from developedBySJ May 17, 2022 10:25
@nihal467
Copy link
Member

@rithviknishad @gigincg test failed, the shortcuts are not working, and also give a hint like button so that the user can refer to the shortcut

@rithviknishad
Copy link
Member Author

  • Added shortcut keys for patient feed.
  • Added help menu that lists all shortcut keys (in both asset cam feed and patient feed)

image

image

@nihal467
Copy link
Member

test approved

@gigincg gigincg merged commit 4a73c46 into coronasafe:develop May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gigincg gigincg gigincg approved these changes

@developedBySJ developedBySJ Awaiting requested review from developedBySJ

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Keyboard Shortcuts for Camera Live Feed
4 participants
@rithviknishad @nihal467 @gigincg @developedBySJ