-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgraded raviger to v4 #2407
upgraded raviger to v4 #2407
Conversation
@cp-Coder @gigincg can you check the deploy issue |
@nihal467 This PR is good for testing |
@cp-Coder is attempting to deploy a commit to the Coronasafe Team on Vercel. A member of the Team first needs to authorize it. |
@nihal467 Any updates on this PR? |
@cp-Coder test failed
|
Updates
|
a427598
to
c82597b
Compare
@nihal467 there is no problem with save button in the external result. |
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
757392 | Google API Key | 2cec8ae | src/Common/env.tsx | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
@nihal467 that is not a problem in my PR. That's the problem in the whole staging server. Yesterday, a wrong PR was merged which caused that error. That PR has been reverted. So it will probably take some time until that feature is up and running |
@cp-Coder can you merge the latest version, i can't file a consultation update |
@nihal467 Merged the develop branch. This PR is good for testing. |
test approved |
@@ -68,7 +68,7 @@ export default function Breadcrumbs(props: any) { | |||
</Link> | |||
</div> | |||
</li> | |||
{!showFullPath && crumbs.length > 2 && ( | |||
{!showFullPath && crumbs!.length > 2 && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{!showFullPath && crumbs!.length > 2 && ( | |
{!showFullPath && crumbs?.length > 2 && ( |
shouldn't it supposed to be ?
instead of !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khavinshankar It should be !
not ?
. The reason is crumbs
can possibly be undefined because in the new version of raviger, usePath()
can return null.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cp-Coder can you check it once please |
@khavinshankar I have made the changes |
@khavinshankar I have updated the logic |
Updates