Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgraded raviger to v4 #2407

Merged
merged 4 commits into from
Jul 6, 2022
Merged

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented May 18, 2022

Updates

@aeswibon aeswibon requested a review from a team May 18, 2022 04:43
@aeswibon aeswibon requested a review from a team as a code owner June 4, 2022 15:31
@nihal467
Copy link
Member

nihal467 commented Jun 5, 2022

@cp-Coder @gigincg can you check the deploy issue

@nihal467 nihal467 added Deploy-Failed Deplyment is not showing preview and removed needs testing labels Jun 5, 2022
@aeswibon aeswibon added needs testing and removed Deploy-Failed Deplyment is not showing preview labels Jun 5, 2022
@aeswibon
Copy link
Member Author

aeswibon commented Jun 5, 2022

@nihal467 This PR is good for testing

@vercel
Copy link

vercel bot commented Jun 18, 2022

@cp-Coder is attempting to deploy a commit to the Coronasafe Team on Vercel.

A member of the Team first needs to authorize it.

@aeswibon
Copy link
Member Author

@nihal467 Any updates on this PR?

@nihal467
Copy link
Member

nihal467 commented Jun 24, 2022

@cp-Coder test failed

10

  • the heading of the consultation page is having misaligned
  • the create investigation button is not working

11

  • view/upload patient button is not working, malfunctioning

12

  • save user button after clicking, is staying in the same page

13

  • save button malfunction in the external result

14

  • noticeboard tab is malfunction, it is showing no data

@aeswibon
Copy link
Member Author

aeswibon commented Jun 25, 2022

Updates

  • Heading of the consultation page is misaligned
  • Create Investigation button is not working
  • View/Upload Patient Files button is not working
  • After clicking the Save User button, the site is still showing the same page
  • Save button malfunctions in the external result
  • Noticeboard tab is malfunctioning

@aeswibon
Copy link
Member Author

@nihal467 there is no problem with save button in the external result.
In the above photo, the save button is disabled because the csv file is incomplete. It doesn't have local_body column.

@gitguardian
Copy link

gitguardian bot commented Jun 27, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
757392 Google API Key 2cec8ae src/Common/env.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@nihal467
Copy link
Member

@cp-Coder test failed

2

  • unable to file consultation

@aeswibon
Copy link
Member Author

@nihal467 that is not a problem in my PR. That's the problem in the whole staging server. Yesterday, a wrong PR was merged which caused that error. That PR has been reverted. So it will probably take some time until that feature is up and running

@nihal467
Copy link
Member

nihal467 commented Jul 3, 2022

@cp-Coder can you merge the latest version, i can't file a consultation update

@aeswibon
Copy link
Member Author

aeswibon commented Jul 3, 2022

@nihal467 Merged the develop branch. This PR is good for testing.

@nihal467
Copy link
Member

nihal467 commented Jul 3, 2022

test approved

@@ -68,7 +68,7 @@ export default function Breadcrumbs(props: any) {
</Link>
</div>
</li>
{!showFullPath && crumbs.length > 2 && (
{!showFullPath && crumbs!.length > 2 && (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{!showFullPath && crumbs!.length > 2 && (
{!showFullPath && crumbs?.length > 2 && (

shouldn't it supposed to be ? instead of !

Copy link
Member Author

@aeswibon aeswibon Jul 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khavinshankar It should be ! not ?. The reason is crumbs can possibly be undefined because in the new version of raviger, usePath() can return null.

Copy link
Member

@khavinshankar khavinshankar Jul 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cp-Coder Is it new syntax?,
image

@khavinshankar
Copy link
Member

@cp-Coder can you check it once please

@aeswibon
Copy link
Member Author

aeswibon commented Jul 6, 2022

@khavinshankar I have made the changes

@aeswibon
Copy link
Member Author

aeswibon commented Jul 6, 2022

@khavinshankar I have updated the logic

@khavinshankar khavinshankar merged commit 04690e2 into coronasafe:develop Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update raviger; breaking changes
3 participants